Review main Merged

66319[TASK] Always handle linktypes in linkvalidator as list

Sybille Peters CR +2 V +2 Normal +41 −78 updated 01/05/21, 16:28

Commit message

The TSconfig of linkvalidator contains 'linktypes' which is a
list of link types which should be checked
(e.g. 'external','db' ...).

This list of links can have 2 different formats inside internal code:

['external', 'db']
or

[
   'external' => 1,
   'db' => 1
]

Converting this in various places made the code hard to read and error
prone.

Only the first format is now used, which also makes it possible to
simplify the tests.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1623

  1. Sybille Peters uploaded patch set 1 10/27/20, 16:22

  2. TYPO3com voted on patch set 1 V -1 10/27/20, 16:34 Completed build in 11m 55s on Tue, 27 Oct, 04:34 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6917

  3. Sybille Peters uploaded patch set 2 10/27/20, 18:24

  4. TYPO3com voted on patch set 2 V +1 10/27/20, 18:53 Completed build in 28m 03s on Tue, 27 Oct, 06:53 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6937

  5. Sybille Peters wrote 11/03/20, 14:59

    Topic set to Linkvalidator
  6. Sybille Peters commented on patch set 2 CR -1 11/20/20, 15:17

    Fixing merge conflict
  7. Sybille Peters uploaded patch set 3 11/20/20, 15:21

  8. Sybille Peters rebased onto patch set 4 11/20/20, 15:22

  9. Sybille Peters wrote 11/20/20, 15:22

    Description set to "Resolved merge conflicts"
  10. TYPO3com voted on patch set 4 V +1 11/20/20, 15:36 Completed build in 11m 44s on Fri, 20 Nov, 03:36 PM Test Summary: 32389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7474

  11. TYPO3com voted on patch set 3 V -1 11/20/20, 15:41 Completed build in 16m 23s on Fri, 20 Nov, 03:41 PM Test Summary: 1 of 32630 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7473

  12. Benni Mack commented on patch set 4 11/20/20, 15:45

    Overall nice improvement, just one remark

    LinkAnalyzer.php:197

    let's use "in_array($key, $linkTypes, true)" if you know that you only compare strings with strings
  13. Sybille Peters uploaded patch set 5 11/20/20, 18:24

  14. Sybille Peters commented on patch set 5 11/20/20, 18:24

    LinkAnalyzer.php:197 Reply

    Done
  15. TYPO3com voted on patch set 5 V +1 11/20/20, 18:35 Completed build in 10m 49s on Fri, 20 Nov, 06:35 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7494

  16. Sybille Peters uploaded patch set 6 12/14/20, 09:46

  17. TYPO3com voted on patch set 6 V -1 12/14/20, 09:57 Completed build in 11m 13s on Mon, 14 Dec, 09:57 AM Test Summary: 1 of 31090 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8146

  18. TYPO3com voted on patch set 6 V +1 12/14/20, 11:40 Completed build in 09m 50s on Mon, 14 Dec, 11:40 AM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8152

  19. Tymoteusz Motylewski voted on patch set 6 CR +1 12/31/20, 11:02

  20. Benni Mack voted on patch set 6 V +1 CR +1 01/05/21, 07:59

  21. Oli Bartsch voted on patch set 6 V +1 CR +1 01/05/21, 14:33

  22. Benni Mack voted on patch set 6 V +2 CR +2 01/05/21, 16:25

  23. Benni Mack merged patch set 7 01/05/21, 16:28