66319[TASK] Always handle linktypes in linkvalidator as list
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Tymoteusz Motylewski +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+8 −1
- typo3/sysext/linkvalidator/Classes/Repository/BrokenLinkRepository.php+4 −0
- typo3/sysext/linkvalidator/Classes/Result/LinkAnalyzerResult.php+1 −1
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+1 −1
- typo3/sysext/linkvalidator/Classes/LinkAnalyzer.php2+11 −7
- typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php+8 −36
- typo3/sysext/linkvalidator/Tests/Functional/LinkAnalyzerTest.php+8 −32
Review log 1623
-
Sybille Peters uploaded patch set 1 10/27/20, 16:22
-
TYPO3com voted on patch set 1 V -1 10/27/20, 16:34 Completed build in 11m 55s on Tue, 27 Oct, 04:34 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6917
-
Sybille Peters uploaded patch set 2 10/27/20, 18:24
-
TYPO3com voted on patch set 2 V +1 10/27/20, 18:53 Completed build in 28m 03s on Tue, 27 Oct, 06:53 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6937
-
Sybille Peters wrote 11/03/20, 14:59
Topic set to Linkvalidator -
Sybille Peters commented on patch set 2 CR -1 11/20/20, 15:17
Fixing merge conflict -
Sybille Peters uploaded patch set 3 11/20/20, 15:21
-
Sybille Peters rebased onto patch set 4 11/20/20, 15:22
-
Sybille Peters wrote 11/20/20, 15:22
Description set to "Resolved merge conflicts" -
TYPO3com voted on patch set 4 V +1 11/20/20, 15:36 Completed build in 11m 44s on Fri, 20 Nov, 03:36 PM Test Summary: 32389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7474
-
TYPO3com voted on patch set 3 V -1 11/20/20, 15:41 Completed build in 16m 23s on Fri, 20 Nov, 03:41 PM Test Summary: 1 of 32630 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7473
-
Benni Mack commented on patch set 4 11/20/20, 15:45
Overall nice improvement, just one remarkLinkAnalyzer.php:197let's use "in_array($key, $linkTypes, true)" if you know that you only compare strings with strings -
Sybille Peters uploaded patch set 5 11/20/20, 18:24
-
Sybille Peters commented on patch set 5 11/20/20, 18:24
LinkAnalyzer.php:197ReplyDone -
TYPO3com voted on patch set 5 V +1 11/20/20, 18:35 Completed build in 10m 49s on Fri, 20 Nov, 06:35 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7494
-
Sybille Peters uploaded patch set 6 12/14/20, 09:46
-
TYPO3com voted on patch set 6 V -1 12/14/20, 09:57 Completed build in 11m 13s on Mon, 14 Dec, 09:57 AM Test Summary: 1 of 31090 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8146
-
TYPO3com voted on patch set 6 V +1 12/14/20, 11:40 Completed build in 09m 50s on Mon, 14 Dec, 11:40 AM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8152
-
Tymoteusz Motylewski voted on patch set 6 CR +1 12/31/20, 11:02
-
Benni Mack voted on patch set 6 V +1 CR +1 01/05/21, 07:59
-
Oli Bartsch voted on patch set 6 V +1 CR +1 01/05/21, 14:33
-
Benni Mack voted on patch set 6 V +2 CR +2 01/05/21, 16:25
-
Benni Mack merged patch set 7 01/05/21, 16:28