Review main Merged

66320[TASK] Add aria-label atributes to topbar icons

Michael Telgkamp CR +2 V +2 Easy +9 −3 updated 10/29/20, 18:13

Commit message

To announce the buttons correctly when using assistive technologies
there needs to be an aria-label, as there will not be a real label
attached to the top bar buttons.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Michael Telgkamp +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Michael Telgkamp +1
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 89

  1. Michael Telgkamp uploaded patch set 1 10/27/20, 16:22

  2. Michael Telgkamp wrote 10/27/20, 16:23

    Topic set to a11y
  3. TYPO3com voted on patch set 1 V +1 10/27/20, 16:40 Completed build in 17m 21s on Tue, 27 Oct, 04:40 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6918

  4. Benni Mack voted on patch set 1 V +1 CR +1 10/29/20, 09:57

  5. Oliver Klee voted on patch set 1 CR +1 10/29/20, 10:24

  6. Michael Telgkamp voted on patch set 1 V +1 CR +1 10/29/20, 13:31

  7. Oli Bartsch voted on patch set 1 V +1 CR +1 10/29/20, 16:11

  8. Christian Kuhn voted on patch set 1 V +2 CR +2 10/29/20, 18:13

  9. Christian Kuhn merged patch set 2 10/29/20, 18:13