Review main Merged

66321[TASK] Skip disabled tabs for keyboard users

Michael Telgkamp CR +2 V +2 Easy +7 −2 updated 10/30/20, 08:14

Commit message

Add tabindex of -1 to disabled tab links to remove them from the tab
keyboard navigation

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Michael Telgkamp uploaded patch set 1 10/27/20, 16:36

  2. Michael Telgkamp wrote 10/27/20, 16:36

    Topic set to a11y
  3. TYPO3com voted on patch set 1 V +1 10/27/20, 16:52 Completed build in 15m 08s on Tue, 27 Oct, 04:52 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6920

  4. Georg Ringer voted on patch set 1 V +1 CR +1 10/29/20, 20:58

  5. Oliver Klee voted on patch set 1 CR +1 10/29/20, 21:43

  6. Daniel Goerz voted on patch set 1 V +2 CR +2 10/30/20, 08:14

  7. Daniel Goerz merged patch set 2 10/30/20, 08:14