66323[TASK] Avoid using ControllerContext, and use Extbase Request instead
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Markus Klein +1
-
Verified V +2 Done
- Georg Ringer +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 29
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php+1 −4
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLayout/Button/ShortcutButtonViewHelper.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/Form/TranslateLabelSelectViewHelper.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/ControllerContext.php+8 −0
- typo3/sysext/extensionmanager/Classes/ViewHelpers/DownloadExtensionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php+58 −7
- typo3/sysext/fluid/Classes/View/StandaloneView.php+4 −14
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/CshViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Buttons/ShortcutViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Labels/CshViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/Menus/ActionMenuItemViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/ContainerViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Form/AbstractFormFieldViewHelper.php+3 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Form/ValidationResultsViewHelper.php+1 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Link/ActionViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Link/PageViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ActionViewHelper.php+1 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/PageViewHelper.php+1 −3
Show 9 more files
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/ResourceViewHelper.php+2 −2
- typo3/sysext/fluid/Classes/ViewHelpers/BaseViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+3 −4
- typo3/sysext/fluid/Classes/ViewHelpers/TranslateViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Link/PageViewHelperTest.php+2 −11
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/Uri/PageViewHelperTest.php+7 −1
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php+9 −2
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/FluidTemplateContentObject.php+1 −1
Review log 1629
Show 34 earlier messages
-
Benni Mack uploaded patch set 1 10/27/20, 16:47
-
TYPO3com voted on patch set 1 V -1 10/27/20, 17:05 Completed build in 14m 03s on Tue, 27 Oct, 05:05 PM Test Summary: 768 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6923
-
Alexander Schnitzler wrote 10/28/20, 07:17
Topic set to Extbase -
Benni Mack uploaded patch set 2 11/07/20, 10:27
-
TYPO3com voted on patch set 2 V -1 11/07/20, 10:39 Completed build in 11m 40s on Sat, 7 Nov, 10:39 AM Test Summary: 59 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7162
-
Benni Mack uploaded patch set 3 11/07/20, 12:13
-
TYPO3com voted on patch set 3 V -1 11/07/20, 12:33 Completed build in 15m 39s on Sat, 7 Nov, 12:33 PM Test Summary: 25 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7167
-
Benni Mack uploaded patch set 4 11/07/20, 13:10
-
TYPO3com voted on patch set 4 V -1 11/07/20, 13:22 Completed build in 11m 11s on Sat, 7 Nov, 01:22 PM Test Summary: 1 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7169
-
TYPO3com commented on patch set 4 11/07/20, 13:31 Completed build in 31m 45s on Sat, 7 Nov, 01:31 PM Test Summary: 1 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7169
-
Benni Mack uploaded patch set 5 11/07/20, 14:19
-
TYPO3com voted on patch set 5 V -1 11/07/20, 14:21 Completed build in 33s on Sat, 7 Nov, 02:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7171
-
Benni Mack uploaded patch set 6 11/07/20, 14:27
-
TYPO3com voted on patch set 6 V -1 11/07/20, 14:39 Completed build in 12m 02s on Sat, 7 Nov, 02:39 PM Test Summary: 60 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7172
-
Benni Mack uploaded patch set 7 11/07/20, 14:53
-
TYPO3com voted on patch set 7 V -1 11/07/20, 15:04 Completed build in 11m 30s on Sat, 7 Nov, 03:04 PM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7173
-
Benni Mack uploaded patch set 8 11/10/20, 11:12
-
TYPO3com voted on patch set 8 V -1 11/10/20, 11:25 Completed build in 12m 14s on Tue, 10 Nov, 11:25 AM Test Summary: 153 of 74126 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7215
-
Benni Mack uploaded patch set 9 11/10/20, 11:37
-
TYPO3com voted on patch set 9 V -1 11/10/20, 11:52 Completed build in 14m 41s on Tue, 10 Nov, 11:52 AM Test Summary: 73629 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7217
-
TYPO3com voted on patch set 9 V +1 11/10/20, 11:56 Completed build in 33m 33s on Tue, 10 Nov, 11:56 AM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7217
-
Benni Mack updated the commit message in patch set 10 11/11/20, 09:20
-
TYPO3com voted on patch set 10 V +1 11/11/20, 09:31 Completed build in 11m 45s on Wed, 11 Nov, 09:31 AM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7239
-
Benni Mack uploaded patch set 11 11/12/20, 10:38
-
TYPO3com voted on patch set 11 V +1 11/12/20, 10:50 Completed build in 12m 25s on Thu, 12 Nov, 10:50 AM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7266
-
Markus Klein voted on patch set 11 CR +1 11/12/20, 10:50
-
Markus Klein voted on patch set 11 V +1 11/12/20, 21:51
-
Georg Ringer voted on patch set 11 V +2 CR +2 11/13/20, 05:56
-
Georg Ringer merged patch set 12 11/13/20, 05:56