Review main Merged

66324[TASK] Create TER remote instances in symfony service factory

Benjamin Franzke CR +2 V +2 Easy +2 −25 updated 10/27/20, 20:22

Commit message

The remotes are not lazy loaded, therefore there is no need to
inject the container instance into RemoteRegistry.

We can pass the remote instances directly into the
registerRemote method, that has the slight benefit
of avoiding roundtrips and the symfony service defintions
can be inlined/optimized (the remote instances are
created withing the generated RemoteRegistry factory).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 45

  1. Benjamin Franzke uploaded patch set 1 10/27/20, 19:05

  2. TYPO3com voted on patch set 1 V +1 10/27/20, 19:21 Completed build in 15m 39s on Tue, 27 Oct, 07:21 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6939

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 10/27/20, 20:20

  4. Benni Mack voted on patch set 1 V +2 CR +2 10/27/20, 20:21

  5. Benni Mack merged patch set 2 10/27/20, 20:22