Review main Abandoned

66326[WIP][PoC] Introduce ApplicationScope

Benni Mack CR 0 V 0 Normal +138 −42 updated 11/05/20, 10:59

Commit message

Get rid of TYPO3_MODE, and add a class, similar to
Environment which is set at the SystemEnvironmentBuilder
and can be overriden.

This way, it is possible to bootstrap a subrequest
of TYPO3.

Also, the EnvironmentService of Extbase is not needed
anymore.

ToDo:
* We need a pre-patch, sorting out the TYPO3_REQUESTTYPE_AJAX
first, and fix the Install Tool checks.

Review

  • Code review CR 0
  • Verified V 0

Files 32

Show 12 more files

Review log 34

  1. Benni Mack uploaded patch set 1 10/27/20, 20:49

  2. TYPO3com voted on patch set 1 V -1 10/27/20, 21:04 Completed build in 14m 42s on Tue, 27 Oct, 09:04 PM Test Summary: 3 of 74033 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6943

  3. Alexander Schnitzler commented on patch set 1 10/28/20, 07:15

    ApplicationScope.php:28 Unresolved

    If this should be a replacement for the Extbase ExtensionService, we need internal methods to manipulate the state to be able to use this in tests. Of course rewriting the tests would be better but it's not possible yet.

    ApplicationScope.php:30 Unresolved

    Why not make this class a BitSet?
  4. Benni Mack abandoned the change 11/05/20, 10:59

    not needed