Review main Merged

66327[TASK] Add page ID prefix to page cache and lock identifiers

Tymoteusz Motylewski CR +2 V +2 Easy +4 −4 updated 11/01/20, 18:25

Commit message

This make it easier to debug/monitor cache/lock related issues.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1013

  1. Tymoteusz Motylewski uploaded patch set 1 10/27/20, 21:56

  2. Tymoteusz Motylewski updated the commit message in patch set 2 10/27/20, 22:00

  3. TYPO3com voted on patch set 1 V +1 10/27/20, 22:27 Completed build in 14m 52s on Tue, 27 Oct, 10:27 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6949

  4. TYPO3com voted on patch set 2 V +1 10/27/20, 22:31 Completed build in 18m 54s on Tue, 27 Oct, 10:31 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6950

  5. Georg Ringer voted on patch set 2 V +1 CR +1 10/28/20, 06:12

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 10/28/20, 10:07

  7. Christian Kuhn voted on patch set 2 V 0 CR 0 10/28/20, 10:08

  8. Christian Kuhn commented on patch set 2 10/28/20, 10:08

    TypoScriptFrontendController.php:1673 Unresolved

    @return description is wrong now.
  9. Tymoteusz Motylewski uploaded patch set 3 10/28/20, 11:59

  10. TYPO3com voted on patch set 3 V +1 10/28/20, 12:13 Completed build in 14m 51s on Wed, 28 Oct, 12:13 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6971

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 10/28/20, 12:20

  12. Georg Ringer voted on patch set 3 V +2 CR +2 11/01/20, 18:25

  13. Georg Ringer merged patch set 4 11/01/20, 18:25