Review main Merged

66328[BUGFIX] Use correct format character in CleanerTaskTest

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 10/28/20, 08:49

Commit message

The CleanerTaskTest creates a DateInterval and formats it
to return the day representation of the difference. Therefore,
the `%d` format character was used. Because `%d` does only
output the number of days not already covered by the month,
the test now failed.

The `%a` format character is now used as it will always output
the total number of days.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 10/28/20, 08:32

  2. Andreas Kienast voted on patch set 1 CR +1 10/28/20, 08:34

  3. Benni Mack voted on patch set 1 V +1 CR +1 10/28/20, 08:44

  4. TYPO3com voted on patch set 1 V +1 10/28/20, 08:44 Completed build in 11m 58s on Wed, 28 Oct, 08:44 AM Test Summary: 73558 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6956

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 10/28/20, 08:49

  6. Andreas Kienast merged patch set 2 10/28/20, 08:49