Review main Merged

66330[BUGFIX] Do not try to evaluate fe_groups for page overlays

Markus Klein CR +2 V +2 Easy +30 −9 updated 11/17/20, 08:19

Commit message

The access settings is an exclude field and hence
the value is synchronized to the translation.
Fetching the translation overlay therefore does
not need to evaluate the fe_groups again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1013

  1. Markus Klein uploaded patch set 1 10/28/20, 15:53

  2. TYPO3com voted on patch set 1 V +1 10/28/20, 16:06 Completed build in 12m 28s on Wed, 28 Oct, 04:06 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6977

  3. Daniel Huf commented on patch set 1 V +1 CR +1 10/28/20, 21:48

    Works on my v9 setup. Thanks a lot
  4. Benni Mack commented on patch set 1 11/03/20, 19:46

    I wish we would have at least 1 unit test to ensure that somebody will never add this again in a few versions and remember this change.
  5. Benni Mack voted on patch set 1 CR +2 11/03/20, 19:57

  6. Markus Klein commented on patch set 1 V -1 11/06/20, 19:09

    will try to come up with tests
  7. Markus Klein uploaded patch set 2 11/10/20, 15:34

  8. TYPO3com voted on patch set 2 V +1 11/10/20, 15:45 Completed build in 11m 28s on Tue, 10 Nov, 03:45 PM Test Summary: 73644 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7223

  9. Benni Mack commented on patch set 3 11/11/20, 08:10

    Published edit on patch set 2.
  10. TYPO3com voted on patch set 3 V +1 11/11/20, 08:28 Completed build in 15m 04s on Wed, 11 Nov, 08:28 AM Test Summary: 73644 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7236

  11. Benni Mack voted on patch set 3 V +1 CR +1 11/16/20, 15:15

  12. Benni Mack voted on patch set 3 V +2 CR +2 11/17/20, 08:19

  13. Benni Mack merged patch set 4 11/17/20, 08:19