Review 10.4 Merged

66332[BUGFIX] Do not re-set PreviewAspect when initializing TSFE

Benni Mack CR +2 V +2 Easy +0 −2 updated 10/27/20, 16:59

Commit message

When the Admin Panel is activated, TSFE should not
override the frontendpreview aspect by default, as
the preview settings will never work otherwise.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 711

  1. Benni Mack commented on patch set 1 10/27/20, 16:35

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Middleware/TypoScriptFrontendInitialization.php
  2. TYPO3com voted on patch set 1 V -1 10/27/20, 16:36 Completed build in 27s on Tue, 27 Oct, 04:36 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-688

  3. Benni Mack commented on patch set 2 10/27/20, 16:37

    Published edit on patch set 1.
  4. Benni Mack commented on patch set 3 10/27/20, 16:37

    Published edit on patch set 2.
  5. Benni Mack commented on patch set 4 10/27/20, 16:37

    Published edit on patch set 3.
  6. Benni Mack commented on patch set 4 10/27/20, 16:37

    This change is ready for review.
  7. TYPO3com voted on patch set 2 V -1 10/27/20, 16:38 Completed build in 34s on Tue, 27 Oct, 04:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-689

  8. TYPO3com voted on patch set 3 V -1 10/27/20, 16:38 Completed build in 31s on Tue, 27 Oct, 04:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-690

  9. TYPO3com voted on patch set 4 V +1 10/27/20, 16:59 Completed build in 21m 07s on Tue, 27 Oct, 04:59 PM Test Summary: 74958 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-691

  10. Benni Mack voted on patch set 4 V +2 CR +2 10/27/20, 16:59

  11. Benni Mack merged patch set 5 10/27/20, 16:59