Review 10.4 Merged

66339[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core Database

Benni Mack CR +2 V +2 Normal +139 −37 updated 10/29/20, 21:48

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 34

  1. Benni Mack commented on patch set 1 10/29/20, 20:42

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/29/20, 20:55 Completed build in 12m 43s on Thu, 29 Oct, 08:55 PM Test Summary: 74958 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-698

  3. Benni Mack voted on patch set 1 V +2 CR +2 10/29/20, 21:48

  4. Benni Mack merged patch set 2 10/29/20, 21:48