Review 10.4 Merged

66341[BUGFIX] Use default page id for fetching a site in SlugService

Andreas Kienast CR +2 V +2 Normal +102 −1 updated 10/30/20, 13:21

Commit message

The rebuildSlugsForSlugChange function of SlugService updates
slugs of sub pages and also creates redirects for them, after
changing the slug of their parent page. This process requires
to fetch the corresponding site configuration.

In cases like changing the slug of a localized root page
this throws a SiteNotFoundException, because the site is
always mapped to the default page id which can not be
determined for localized root pages because their pid is 0.

It's therefore necessary to always use the default page
id for fetching the site through SiteFinder.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Andreas Kienast commented on patch set 1 10/30/20, 12:32

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/30/20, 12:44 Completed build in 11m 27s on Fri, 30 Oct, 12:44 PM Test Summary: 74961 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-703

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 10/30/20, 13:21

  4. Andreas Kienast merged patch set 2 10/30/20, 13:21