Review main Merged

66353[BUGFIX] Use default page id for fetching a site in SlugService

Oli Bartsch CR +2 V +2 Normal +102 −1 updated 10/30/20, 12:32

Commit message

The rebuildSlugsForSlugChange function of SlugService updates
slugs of sub pages and also creates redirects for them, after
changing the slug of their parent page. This process requires
to fetch the corresponding site configuration.

In cases like changing the slug of a localized root page
this throws a SiteNotFoundException, because the site is
always mapped to the default page id which can not be
determined for localized root pages because their pid is 0.

It's therefore necessary to always use the default page
id for fetching the site through SiteFinder.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 711

  1. Oli Bartsch uploaded patch set 1 10/29/20, 11:58

  2. TYPO3com voted on patch set 1 V +1 10/29/20, 12:10 Completed build in 11m 40s on Thu, 29 Oct, 12:10 PM Test Summary: 73553 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6998

  3. Oli Bartsch uploaded patch set 2 10/29/20, 12:38

  4. TYPO3com voted on patch set 2 V +1 10/29/20, 12:50 Completed build in 12m 00s on Thu, 29 Oct, 12:50 PM Test Summary: 73557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6999

  5. Oli Bartsch updated the commit message in patch set 3 10/29/20, 13:25

  6. TYPO3com voted on patch set 3 V +1 10/29/20, 13:46 Completed build in 16m 34s on Thu, 29 Oct, 01:46 PM Test Summary: 73557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7004

  7. Oli Bartsch uploaded patch set 4 10/29/20, 14:00

  8. TYPO3com voted on patch set 4 V +1 10/29/20, 14:13 Completed build in 13m 28s on Thu, 29 Oct, 02:13 PM Test Summary: 73557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7007

  9. Benni Mack voted on patch set 4 V +1 CR +1 10/30/20, 09:01

  10. Andreas Kienast voted on patch set 4 V +2 CR +2 10/30/20, 12:32

  11. Andreas Kienast merged patch set 5 10/30/20, 12:32