66357[BUGFIX] Return timestamp as integer in DateTimeAspect
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1822
-
Oli Bartsch uploaded patch set 1 10/30/20, 13:53
-
Mathias Brodala commented on patch set 1 10/30/20, 13:58
-
Oli Bartsch uploaded patch set 2 10/30/20, 14:01
-
Oli Bartsch commented on patch set 2 10/30/20, 14:02
DateTimeAspect.php:68ReplyDone -
TYPO3com voted on patch set 1 V +1 10/30/20, 14:05 Completed build in 12m 25s on Fri, 30 Oct, 02:05 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7035
-
Mathias Brodala voted on patch set 2 CR +1 10/30/20, 14:10
-
TYPO3com voted on patch set 2 V +1 10/30/20, 14:13 Completed build in 11m 37s on Fri, 30 Oct, 02:13 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7036
-
Andreas Kienast commented on patch set 2 10/30/20, 14:14
I wonder how breaking this will be for extensions depending on this "feature". -
Mathias Brodala commented on patch set 2 10/30/20, 14:25
> Patch Set 2: > > I wonder how breaking this will be for extensions depending on this "feature". Good question indeed. If you rely on this and pass this value to a method type hinted as "string", you'll get an error with strict_types ... -
Oli Bartsch commented on patch set 2 10/30/20, 14:58
> Patch Set 2: > > > Patch Set 2: > > > > I wonder how breaking this will be for extensions depending on this "feature". > > Good question indeed. If you rely on this and pass this value to a method type hinted as "string", you'll get an error with strict_types ... I think we all agree that a timestamp must be an integer, according to its definition. I can't imagine that extensions actively depend on this being a string. Actually my extensions currently have `(int)DateTimeAspect->get('timestamp')` set all over the place, which is in fact really annoying. What do you think about adding an important rst here, to inform about this bugfix and that people have to adjust their code if they actively rely on it? Otherwise, I fear, we can't fix such bugs in released versions anymore if we always consider every possibility how a bug could be used as a feature. -
Oliver Klee voted on patch set 2 CR +1 10/30/20, 15:03
-
Benni Mack commented on patch set 2 10/30/20, 15:03
Fabulous example on what the definition of a breaking change would be... It fixes a bug and a wrong behaviour. But it might be breaking. I'm most definitively against a Breaking RST for such a change (otherwise we'd really need to write Breaking.RSTs for so many changes we've done until now for v11). Important.rst would be fine, but still overkill in my opinion (but it's better to have more docs than less). But since this causes a discussion (which is good!), I recommend with a "master-only" target release (with or without RST I don't mind). Why master-only? Because we don't want people who depend on the string for now have an issue when upgrading from 10.4.9 to 10.4.10. -
Oli Bartsch uploaded patch set 3 10/30/20, 15:42
-
Oli Bartsch commented on patch set 3 10/30/20, 15:44
> Patch Set 2: > > Fabulous example on what the definition of a breaking change would be... It fixes a bug and a wrong behaviour. But it might be breaking. > > I'm most definitively against a Breaking RST for such a change (otherwise we'd really need to write Breaking.RSTs for so many changes we've done until now for v11). Important.rst would be fine, but still overkill in my opinion (but it's better to have more docs than less). > > But since this causes a discussion (which is good!), I recommend with a "master-only" target release (with or without RST I don't mind). Why master-only? Because we don't want people who depend on the string for now have an issue when upgrading from 10.4.9 to 10.4.10. Thanks for your input. I changed the patch to "master-only" and added the important rst. -
TYPO3com voted on patch set 3 V +1 10/30/20, 15:54 Completed build in 11m 12s on Fri, 30 Oct, 03:54 PM Test Summary: 73568 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7037
-
Oliver Klee voted on patch set 3 CR +1 10/30/20, 17:33
-
Sybille Peters commented on patch set 3 10/31/20, 19:58
Important-92736-ReturnTimestampAsIntegerInDateTimeAspect.rst:25Unresolved> there code their code -
Anja Leichsenring commented on patch set 4 11/01/20, 07:56
Published edit on patch set 3. -
Anja Leichsenring voted on patch set 4 V +1 CR +1 11/01/20, 07:59
-
TYPO3com voted on patch set 4 V +1 11/01/20, 08:12 Completed build in 15m 15s on Sun, 1 Nov, 08:12 AM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7064
-
Georg Ringer voted on patch set 4 V +2 CR +2 11/01/20, 18:21
-
Georg Ringer merged patch set 5 11/01/20, 18:21
DateTimeAspect.php:68