Review main Merged

66361[BUGFIX] Fix exclusive values in FormEngine's selectMultipleSideBySide

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 10/31/20, 10:46

Commit message

With splitting the FormEngine in smaller parts, a regression has been
introduced in the behavior of selectMultipleSideBySide. This select type
supports "exclusive values" which are mutually exclusively selectable.

However, due to a typo in the fetched (non-existent) data attribute, the
whole behavior was broken. This patch fixes the typo.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 67

  1. Andreas Kienast uploaded patch set 1 10/31/20, 10:15

  2. Susi Moog voted on patch set 1 CR +1 10/31/20, 10:21

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 10/31/20, 10:26

  4. TYPO3com voted on patch set 1 V +1 10/31/20, 10:28 Completed build in 12m 23s on Sat, 31 Oct, 10:28 AM Test Summary: 73557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7045

  5. Riccardo De Contardi commented on patch set 1 V +1 10/31/20, 10:38

    tested on latest master with the example reported on https://forge.typo3.org/issues/92737
  6. Daniel Goerz voted on patch set 1 V +2 CR +2 10/31/20, 10:46

  7. Daniel Goerz merged patch set 2 10/31/20, 10:46