Review 10.4 Merged

66362[BUGFIX] Fix exclusive values in FormEngine's selectMultipleSideBySide

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 10/31/20, 11:10

Commit message

With splitting the FormEngine in smaller parts, a regression has been
introduced in the behavior of selectMultipleSideBySide. This select type
supports "exclusive values" which are mutually exclusively selectable.

However, due to a typo in the fetched (non-existent) data attribute, the
whole behavior was broken. This patch fixes the typo.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 710

  1. Andreas Kienast uploaded patch set 1 10/31/20, 10:17

  2. Oli Bartsch voted on patch set 1 V +1 CR +1 10/31/20, 10:30

  3. TYPO3com voted on patch set 1 V +1 10/31/20, 10:30 Completed build in 12m 38s on Sat, 31 Oct, 10:30 AM Test Summary: 74961 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-705

  4. Daniel Goerz uploaded patch set 2 10/31/20, 10:47

  5. Daniel Goerz commented on patch set 2 10/31/20, 10:48

    oops, did not see there was already a backport ....
  6. Daniel Goerz uploaded patch set 3 10/31/20, 10:49

  7. TYPO3com voted on patch set 2 V -1 10/31/20, 10:58 Completed build in 11m 27s on Sat, 31 Oct, 10:58 AM Test Summary: 7 of 75446 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-706

  8. TYPO3com voted on patch set 3 V +1 10/31/20, 11:03 Completed build in 14m 06s on Sat, 31 Oct, 11:03 AM Test Summary: 74961 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-707

  9. Daniel Goerz voted on patch set 3 V +2 CR +2 10/31/20, 11:10

  10. Daniel Goerz merged patch set 4 10/31/20, 11:10