Review main Merged

66363[BUGFIX] Better handling of "too many redirects" in linkvalidator

Sybille Peters CR +2 V +2 Easy +7 −1 updated 11/10/20, 22:26

Commit message

Previously, if there were too many redirects, an error message
"A redirect loop occurred" was displayed. This was misleading.

A redirect loop is different from "too many redirects". "Too
many redirects simply means that the maximum number of redirects
used by the underlying HTTP request library (Guzzle) is reached
before reaching the destination. This happens by default after
5 redirects.

Therefore, the "too many redirects" error is now being displayed
with its own message.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 911

  1. Sybille Peters uploaded patch set 1 10/31/20, 13:20

  2. Sybille Peters wrote 10/31/20, 13:20

    Topic set to linkvalidator
  3. TYPO3com voted on patch set 1 V +1 10/31/20, 13:33 Completed build in 13m 26s on Sat, 31 Oct, 01:33 PM Test Summary: 73557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7049

  4. Oli Bartsch uploaded patch set 2 11/01/20, 17:49

  5. Oli Bartsch voted on patch set 2 CR +1 11/01/20, 17:50

  6. TYPO3com voted on patch set 2 V +1 11/01/20, 18:01 Completed build in 12m 22s on Sun, 1 Nov, 06:01 PM Test Summary: 73557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7067

  7. Sybille Peters wrote 11/03/20, 14:52

    Topic linkvalidator removed
  8. Sybille Peters wrote 11/03/20, 14:52

    Topic set to Linkvalidator
  9. Guido Schmechel voted on patch set 2 CR +1 11/06/20, 09:51

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 11/10/20, 22:26

  11. Christian Kuhn merged patch set 3 11/10/20, 22:26