66372[BUGFIX] Do not use AdminPanel reference in EXT:frontend code
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Markus Klein +1
- Oliver Hader +1
-
Verified V +2 Done
- Georg Ringer +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2024
-
Benni Mack uploaded patch set 1 11/02/20, 11:49
-
David Steeb voted on patch set 1 CR +1 11/02/20, 11:54
-
TYPO3com voted on patch set 1 V +1 11/02/20, 12:00 Completed build in 11m 32s on Mon, 2 Nov, 12:00 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7069
-
Markus Klein commented on patch set 1 CR -1 11/02/20, 12:19
-
Markus Klein commented on patch set 2 11/02/20, 12:20
Published edit on patch set 1. -
Markus Klein voted on patch set 2 CR +1 11/02/20, 12:21
-
Simon Gilli commented on patch set 2 11/02/20, 12:21
VisibilityAspect.php:81Reply UnresolvedThe last one should be $this->includeDeletedRecords imho -
Simon Gilli commented on patch set 2 CR -1 11/02/20, 12:22
See comment -
Oli Bartsch uploaded patch set 3 11/02/20, 12:24
-
Simon Gilli voted on patch set 3 CR +1 11/02/20, 12:25
-
David Steeb commented on patch set 3 V +1 11/02/20, 12:30
Tested. -
Oli Bartsch voted on patch set 3 CR +1 11/02/20, 12:30
-
Mathias Brodala commented on patch set 3 11/02/20, 12:34
VisibilityAspect.php:79How about "includeHidden" since this seems to cover all cases? Also "include" instead of "includes" for consistency with the existing methods. -
TYPO3com voted on patch set 2 V +1 11/02/20, 12:34 Completed build in 13m 07s on Mon, 2 Nov, 12:34 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7071
-
TYPO3com voted on patch set 3 V +1 11/02/20, 12:38 Completed build in 14m 26s on Mon, 2 Nov, 12:38 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7072
-
Markus Klein commented on patch set 3 11/02/20, 13:35
VisibilityAspect.php:81For my understanding: Why do we trigger a preview for DELETED records? -
Markus Klein commented on patch set 3 CR -1 11/11/20, 19:02
-1 until answer to my question is provided. sorry -
Benni Mack commented on patch set 3 11/12/20, 08:36
VisibilityAspect.php:79Reply UnresolvedCorrect "includes" should be "include". "includeHidden" itself sounds a bit... weird to be honest as it is not clear what that means. "includeAnyHidden"?VisibilityAspect.php:81Reply Unresolvedbecause we don't want to cache "show deleted records" information in the pages cache :) However, I've never used "show deleted records" in FE, and that's currently not even possible to select btw. -
Benni Mack uploaded patch set 4 11/16/20, 11:37
-
TYPO3com voted on patch set 4 V +1 11/16/20, 11:55 Completed build in 18m 01s on Mon, 16 Nov, 11:55 AM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7337
-
Markus Klein voted on patch set 4 V +1 CR +1 11/16/20, 12:34
-
Georg Ringer voted on patch set 4 V +2 CR +2 11/16/20, 13:30
-
Georg Ringer merged patch set 5 11/16/20, 13:30
-
Oliver Hader voted on patch set 5 CR +1 11/16/20, 13:32
VisibilityAspect.php:81