Review main Merged

66372[BUGFIX] Do not use AdminPanel reference in EXT:frontend code

Benni Mack CR +2 V +2 Easy +7 −2 updated 11/16/20, 13:32

Commit message

With this change an undefined symbol is included when not having
AdminPanel loaded: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66218

This change aims to change the logic for checking if the preview
flag is enabled.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 2024

  1. Benni Mack uploaded patch set 1 11/02/20, 11:49

  2. David Steeb voted on patch set 1 CR +1 11/02/20, 11:54

  3. TYPO3com voted on patch set 1 V +1 11/02/20, 12:00 Completed build in 11m 32s on Mon, 2 Nov, 12:00 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7069

  4. Markus Klein commented on patch set 1 CR -1 11/02/20, 12:19

    VisibilityAspect.php:81

    twice?
  5. Markus Klein commented on patch set 2 11/02/20, 12:20

    Published edit on patch set 1.
  6. Markus Klein voted on patch set 2 CR +1 11/02/20, 12:21

  7. Simon Gilli commented on patch set 2 11/02/20, 12:21

    VisibilityAspect.php:81 Reply Unresolved

    The last one should be $this->includeDeletedRecords imho
  8. Simon Gilli commented on patch set 2 CR -1 11/02/20, 12:22

    See comment
  9. Oli Bartsch uploaded patch set 3 11/02/20, 12:24

  10. Simon Gilli voted on patch set 3 CR +1 11/02/20, 12:25

  11. David Steeb commented on patch set 3 V +1 11/02/20, 12:30

    Tested.
  12. Oli Bartsch voted on patch set 3 CR +1 11/02/20, 12:30

  13. Mathias Brodala commented on patch set 3 11/02/20, 12:34

    VisibilityAspect.php:79

    How about "includeHidden" since this seems to cover all cases? Also "include" instead of "includes" for consistency with the existing methods.
  14. TYPO3com voted on patch set 2 V +1 11/02/20, 12:34 Completed build in 13m 07s on Mon, 2 Nov, 12:34 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7071

  15. TYPO3com voted on patch set 3 V +1 11/02/20, 12:38 Completed build in 14m 26s on Mon, 2 Nov, 12:38 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7072

  16. Markus Klein commented on patch set 3 11/02/20, 13:35

    VisibilityAspect.php:81

    For my understanding: Why do we trigger a preview for DELETED records?
  17. Markus Klein commented on patch set 3 CR -1 11/11/20, 19:02

    -1 until answer to my question is provided. sorry
  18. Benni Mack commented on patch set 3 11/12/20, 08:36

    VisibilityAspect.php:79 Reply Unresolved

    Correct "includes" should be "include". "includeHidden" itself sounds a bit... weird to be honest as it is not clear what that means. "includeAnyHidden"?

    VisibilityAspect.php:81 Reply Unresolved

    because we don't want to cache "show deleted records" information in the pages cache :) However, I've never used "show deleted records" in FE, and that's currently not even possible to select btw.
  19. Benni Mack uploaded patch set 4 11/16/20, 11:37

  20. TYPO3com voted on patch set 4 V +1 11/16/20, 11:55 Completed build in 18m 01s on Mon, 16 Nov, 11:55 AM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7337

  21. Markus Klein voted on patch set 4 V +1 CR +1 11/16/20, 12:34

  22. Georg Ringer voted on patch set 4 V +2 CR +2 11/16/20, 13:30

  23. Georg Ringer merged patch set 5 11/16/20, 13:30

  24. Oliver Hader voted on patch set 5 CR +1 11/16/20, 13:32