Review main Abandoned

66374[BUGFIX] Add data attribute to HtmlViewHelper

Stefan Froemken CR 0 V 0 Hard +256 −7 updated 12/23/21, 22:49

Commit message

Add data attribute to HtmlViewHelper to
allow individual if-conditions or CASE in lib.parseFunc.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 915

  1. Stefan Froemken uploaded patch set 1 11/02/20, 13:51

  2. TYPO3com voted on patch set 1 V +1 11/02/20, 14:04 Completed build in 12m 33s on Mon, 2 Nov, 02:04 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7073

  3. Stefan Froemken uploaded patch set 2 11/02/20, 17:09

  4. TYPO3com voted on patch set 2 V -1 11/02/20, 17:09 Completed build in 40s on Mon, 2 Nov, 05:09 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7074

  5. Stefan Froemken uploaded patch set 3 11/02/20, 17:11

  6. TYPO3com voted on patch set 3 V -1 11/02/20, 17:28 Completed build in 16m 06s on Mon, 2 Nov, 05:28 PM Test Summary: 72860 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7075

  7. TYPO3com voted on patch set 3 V +1 11/02/20, 17:43 Completed build in 47m 40s on Mon, 2 Nov, 05:43 PM Test Summary: 73575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7075

  8. Stefan Froemken uploaded patch set 4 11/03/20, 07:27

  9. TYPO3com voted on patch set 4 V +1 11/03/20, 07:39 Completed build in 12m 08s on Tue, 3 Nov, 07:39 AM Test Summary: 73575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7079

  10. Stefan Froemken uploaded patch set 5 11/03/20, 11:06

  11. TYPO3com voted on patch set 5 V -1 11/03/20, 11:18 Completed build in 12m 01s on Tue, 3 Nov, 11:18 AM Test Summary: 7 of 68606 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7085

  12. Oli Bartsch commented on patch set 5 V -1 CR -1 11/03/20, 11:32

    One could argue that this is a feature. However, if we continue as bugfix this must get at least an important.rst as new configuration (arguments) are introduced. I also noticed the example with the new data attribute is the same as without. The user would surely benefit form a dedicated example there to outline what the new functionality is for and maybe also include the other new arguments.

    HtmlViewHelper.php:61 Unresolved

    Since you are already on it, let's remove the whitespace here.

    HtmlViewHelper.php:77 Unresolved

    Should be capitalized?

    HtmlViewHelper.php:142 Unresolved

    Will generate E_NOTICE if not set (which is not required according to the registerArgument call.

    HtmlViewHelper.php:148 Unresolved

    Here we mix access to arguments array and declared variables. Let's unify this and either always use the array or assign each value to a variable.

    HtmlViewHelperTest.php:1 Unresolved

    Please add strict types
  13. Benni Mack abandoned the change 11/03/21, 17:46

    Stefan, I'll abandon this patch for now, this hasn't been touched in a year without adressing the issues, anyone is still free to pick it up so the patch can be rebased.
  14. Stefan Froemken restored the change 12/23/21, 22:38

  15. Stefan Froemken abandoned the change 12/23/21, 22:49

    The new push has created a new Review 72803. Maybe because of changed branch?!