Review main Merged

66375[TASK] Enforce Composer 2 usage for TYPO3 development

Helmut Hummel CR +2 V +2 Expert +987 −654 updated 11/03/20, 13:05

Commit message

To benefit from faster operations and cleaner updates
Composer 2 usage is now enforced by requiring ^2.0
of composer-runtime-api.

Although currently there is no real code dependency yet
to the runtime API introduced for Composer 2, this
requirement enforces usage of Composer 2 for all interactions
with this package (install/ update).

The package is required as dev dependency to still
allow "manual" usage of this package for classic installs
and make the breaking impact low (composer install --no-dev
will still work with Composer 1)

For TYPO3 v11 this dependency will likely be a production
dependency as well.

composer up --lock
composer req --dev composer-runtime-api:^2.0

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 46

  1. Helmut Hummel uploaded patch set 1 11/02/20, 17:14

  2. Helmut Hummel updated the commit message in patch set 2 11/02/20, 17:23

  3. TYPO3com voted on patch set 1 V +1 11/02/20, 17:31 Completed build in 16m 49s on Mon, 2 Nov, 05:31 PM Test Summary: 73567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7076

  4. TYPO3com voted on patch set 2 V +1 11/02/20, 17:37 Completed build in 13m 59s on Mon, 2 Nov, 05:37 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7077

  5. Benni Mack voted on patch set 2 V +2 CR +2 11/03/20, 13:05

  6. Benni Mack merged patch set 3 11/03/20, 13:05