Review main Abandoned

66376[TASK] Move enforcing of referers to Backend middleware

Benni Mack CR 0 V 0 Normal +80 −45 updated 01/22/21, 16:06

Commit message

This change moves the added functionality for adding an
additional layer of security in a middleware and out of the
RouteDispatcher.

The security fix in 2020 added this change so it is
non-intrusive and compatible with all existing stable
branches, however, this change can and should be moved
to a separate middleware.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 67

  1. Benni Mack uploaded patch set 1 11/02/20, 22:42

  2. TYPO3com voted on patch set 1 V +1 11/02/20, 22:56 Completed build in 14m 24s on Mon, 2 Nov, 10:56 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7078

  3. Georg Ringer voted on patch set 1 V +1 CR +1 11/03/20, 09:21

  4. Oliver Hader commented on patch set 1 11/03/20, 16:16

    I'd like to test potential security implications, but don't have time to do that right now...
  5. Oliver Hader voted on patch set 1 CR -1 11/03/20, 16:16

  6. Oliver Hader commented on patch set 1 CR 0 11/29/20, 08:40

    Removing by -1 here since I don't have time right now to come up with alternatives. However, some additional aspects: * with this change, custom middleware stacks won't have referrer checks anymore → devs somehow should be aware of that * next to referrer, `Sec-Fetch` are the next to be evaluated (https://forge.typo3.org/issues/91283) → maybe use a different name than `ReferrerEnforcer` * there should be an important RST file
  7. Benni Mack abandoned the change 01/22/21, 16:06