Review main Merged

66378[BUGFIX] Avoid database errors when translating sys_file (metadata) records

Benni Mack CR +2 V +2 Easy +2 −2 updated 11/06/20, 12:37

Commit message

The TCA definitions for sys_file.fileinfo and sys_file_metadata.fileinfo
were marked "user" but without any database definition, leading
to side-effects when automating translations (e.g. in l10nmgr).

However, they only provide information (= a virtual field), so the
definition should be of type "none".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jo Hasenau +1
    • Oliver Klee +1
    • Guido Schmechel +1
    • Sybille Peters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jo Hasenau +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 89

  1. Benni Mack uploaded patch set 1 11/03/20, 09:43

  2. Oli Bartsch voted on patch set 1 V +1 CR +1 11/03/20, 09:45

  3. TYPO3com voted on patch set 1 V +1 11/03/20, 09:54 Completed build in 10m 40s on Tue, 3 Nov, 09:54 AM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7083

  4. Oliver Klee voted on patch set 1 CR +1 11/03/20, 11:26

  5. Guido Schmechel voted on patch set 1 CR +1 11/06/20, 09:49

  6. Sybille Peters commented on patch set 1 CR +1 11/06/20, 10:24

    fyi, the problem has already been fixed in l10nmgr: https://gitlab.com/coderscare/l10nmgr/-/issues/34 - so you cannot reproduce the problem with latest version.
  7. Jo Hasenau commented on patch set 1 V +1 CR +1 11/06/20, 12:30

    While it still makes sense for l10nmgr to check for DB schema while accessing fields defined in TCA especially by third party extensions, this will at least fix the problem with those two core fields.
  8. Benni Mack voted on patch set 1 V +2 CR +2 11/06/20, 12:37

  9. Benni Mack merged patch set 2 11/06/20, 12:37