Review main Merged

66381[BUGFIX] Fix type error in TCA table wizard for null values

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 11/07/20, 10:33

Commit message

When using renderType textTable for text fields in TCA, the controller
will pass the currently stored value to underlying API. This API always
expects a string. Most of the time those fields might have null as
default in persistence leading to a PHP TypeError.

Therefore a check is added which will fall back to empty string as
proper default for internal API.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Xavier Perseguers +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Daniel Siepmann uploaded patch set 1 11/03/20, 14:36

  2. Daniel Siepmann uploaded patch set 2 11/03/20, 14:36

  3. TYPO3com voted on patch set 1 V -1 11/03/20, 14:48 Completed build in 11m 52s on Tue, 3 Nov, 02:48 PM Test Summary: 10 of 74054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7089

  4. TYPO3com voted on patch set 2 V +1 11/03/20, 14:54 Completed build in 17m 32s on Tue, 3 Nov, 02:54 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7090

  5. Xavier Perseguers voted on patch set 2 CR +1 11/03/20, 15:42

  6. Benni Mack voted on patch set 2 V +1 CR +1 11/03/20, 16:31

  7. Oliver Klee commented on patch set 2 11/03/20, 16:33

    TableController.php:316 Unresolved

    If I read the called method correctly, it returns an empty array if the first parameter is an empty string. So would it make sense to only call the method if the given value is a string, and otherwise directly set $configuration to an empty array?
  8. Oliver Klee commented on patch set 2 CR +1 11/03/20, 16:34

    (I would also be fine with the current solution.)
  9. Oli Bartsch voted on patch set 2 V +1 CR +1 11/03/20, 17:02

  10. Benni Mack commented on patch set 2 V +2 CR +2 11/07/20, 10:33

    Thanks, Oli, I will leave it as is for now
  11. Benni Mack merged patch set 3 11/07/20, 10:33