66382[BUGFIX] Moving pages in workspaces updates pid correctly
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 50
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+16 −7
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/CSV/AbstractActionTestCase.php+9 −1
- typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/AbstractActionTestCase.php+9 −1
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageLocalizedToDifferentPageTwice.csvnew+24 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageToDifferentPageTwice.csvnew+21 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+18 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+77 −0
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php2+7 −1
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Discard/DataSet/moveParentContentToDifferentPageTwice.csvnew+42 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Discard/ActionTest.php+12 −2
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/moveParentContentToDifferentPage.csv+3 −3
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/moveParentContentToDifferentPageNChangeSorting.csv+13 −13
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/DataSet/moveParentContentToDifferentPageTwice.csvnew+53 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Modify/ActionTest.php+9 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/DataSet/moveParentContentToDifferentPageTwice.csvnew+42 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/Publish/ActionTest.php+10 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/DataSet/moveParentContentToDifferentPageTwice.csvnew+42 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/CSV/PublishAll/ActionTest.php+10 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Discard/DataSet/moveParentContentToDifferentPageTwice.csvnew+44 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Discard/ActionTest.php+12 −2
Show 30 more files
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/DataSet/moveParentContentToDifferentPageTwice.csvnew+55 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Modify/ActionTest.php+9 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/DataSet/moveParentContentToDifferentPageTwice.csvnew+44 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/Publish/ActionTest.php+10 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/DataSet/moveParentContentToDifferentPageTwice.csvnew+44 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/IRRE/ForeignField/PublishAll/ActionTest.php+10 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/movePageLocalizedInLiveToDifferentPageTwice.csvnew+27 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/movePageLocalizedInLiveWorkspaceChangedToDifferentPageTwice.csvnew+32 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/movePageLocalizedInLiveWorkspaceDeletedToDifferentPageTwice.csvnew+32 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/movePageLocalizedToDifferentPageTwice.csvnew+29 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/movePageToDifferentPageTwice.csvnew+24 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/ActionTest.php+50 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageLocalizedInLiveToDifferentPageTwice.csvnew+33 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageLocalizedInLiveWorkspaceChangedToDifferentPageTwice.csvnew+33 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageLocalizedInLiveWorkspaceDeletedToDifferentPageTwice.csvnew+34 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageLocalizedToDifferentPageTwice.csvnew+30 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/movePageToDifferentPageTwice.csvnew+26 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+45 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/movePageLocalizedInLiveToDifferentPageTwice.csvnew+31 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/movePageLocalizedInLiveWorkspaceChangedToDifferentPageTwice.csvnew+31 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/movePageLocalizedInLiveWorkspaceDeletedToDifferentPageTwice.csvnew+32 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/movePageLocalizedToDifferentPageTwice.csvnew+28 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/movePageToDifferentPageTwice.csvnew+24 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/ActionTest.php+50 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/movePageLocalizedInLiveToDifferentPageTwice.csvnew+27 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/movePageLocalizedInLiveWorkspaceChangedToDifferentPageTwice.csvnew+27 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/movePageLocalizedInLiveWorkspaceDeletedToDifferentPageTwice.csvnew+28 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/movePageLocalizedToDifferentPageTwice.csvnew+27 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/movePageToDifferentPageTwice.csvnew+24 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/ActionTest.php+50 −0
Review log 1729
Show 24 earlier messages
-
Christian Kuhn uploaded patch set 1 11/03/20, 15:43
-
TYPO3com voted on patch set 1 V -1 11/03/20, 15:55 Completed build in 11m 52s on Tue, 3 Nov, 03:55 PM Test Summary: 6 of 75452 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-710
-
Christian Kuhn uploaded patch set 2 11/04/20, 13:23
-
TYPO3com voted on patch set 2 V -1 11/04/20, 13:38 Completed build in 14m 17s on Wed, 4 Nov, 01:38 PM Test Summary: 6 of 74654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-714
-
Christian Kuhn uploaded patch set 3 11/04/20, 14:12
-
TYPO3com voted on patch set 3 V -1 11/04/20, 14:24 Completed build in 11m 41s on Wed, 4 Nov, 02:24 PM Test Summary: 6 of 75468 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-715
-
Christian Kuhn uploaded patch set 4 11/04/20, 15:43
-
TYPO3com voted on patch set 4 V -1 11/04/20, 15:54 Completed build in 11m 26s on Wed, 4 Nov, 03:54 PM Test Summary: 6 of 75477 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-716
-
Christian Kuhn uploaded patch set 5 11/04/20, 16:12
-
TYPO3com voted on patch set 5 V -1 11/04/20, 16:24 Completed build in 11m 06s on Wed, 4 Nov, 04:24 PM Test Summary: 74992 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-717
-
Christian Kuhn uploaded patch set 6 11/04/20, 17:40
-
TYPO3com voted on patch set 6 V -1 11/04/20, 17:54 Completed build in 13m 04s on Wed, 4 Nov, 05:54 PM Test Summary: 75022 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-720
-
Christian Kuhn uploaded patch set 7 11/04/20, 18:07
-
TYPO3com voted on patch set 7 V -1 11/04/20, 18:18 Completed build in 11m 16s on Wed, 4 Nov, 06:18 PM Test Summary: 75037 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-721
-
Christian Kuhn uploaded patch set 8 11/04/20, 18:31
-
TYPO3com voted on patch set 8 V +1 11/04/20, 18:43 Completed build in 11m 36s on Wed, 4 Nov, 06:43 PM Test Summary: 75027 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-723
-
Christian Kuhn uploaded patch set 9 11/04/20, 19:29
-
TYPO3com voted on patch set 9 V +1 11/04/20, 19:39 Completed build in 10m 32s on Wed, 4 Nov, 07:39 PM Test Summary: 75051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-724
-
Christian Kuhn uploaded patch set 10 11/05/20, 13:30
-
TYPO3com voted on patch set 10 V +1 11/05/20, 13:46 Completed build in 16m 05s on Thu, 5 Nov, 01:46 PM Test Summary: 75075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-727
-
Christian Kuhn updated the commit message in patch set 11 11/05/20, 13:56
-
TYPO3com voted on patch set 11 V +1 11/05/20, 14:40 Completed build in 13m 44s on Thu, 5 Nov, 02:40 PM Test Summary: 75075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-730
-
Benni Mack commented on patch set 11 V +1 CR +1 11/05/20, 16:04
Great work, and thanks for adding so many tests.DataHandler.php:4179I'd say there is a cast (int) missing when reading two lines further.DataHandlerHook.php:1291in the current terms that would be a "move pointer" not a "moveOverlay" ;) but since this code is gone in v11 (for good), this does not matter at all. -
Christian Kuhn commented on patch set 11 11/09/20, 14:05
DataHandler.php:4179Reply Unresolvedgood point. done.DataHandlerHook.php:1291ReplyAck -
Christian Kuhn uploaded patch set 12 11/09/20, 14:08
-
Oli Bartsch voted on patch set 12 V +1 CR +1 11/09/20, 14:29
-
TYPO3com voted on patch set 12 V +1 11/09/20, 14:29 Completed build in 20m 20s on Mon, 9 Nov, 02:29 PM Test Summary: 75063 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-747
-
Benni Mack voted on patch set 12 V +2 CR +2 11/09/20, 14:32
-
Benni Mack merged patch set 13 11/09/20, 14:32