Review 10.4 Merged

66382[BUGFIX] Moving pages in workspaces updates pid correctly

Christian Kuhn CR +2 V +2 Expert +1419 −30 updated 11/09/20, 14:32

Commit message

* (v10) Moving a page that exists in live within
  workspaces multiple times does not upate the pid of
  the t3ver_state=4 overlay.

* (v10, master) Moving a page that has translations
  in workspaces multiple times does not always properly
  update the pid of the translation overlay records to the
  new location.

The patch fixes both issues and adds a series of functional
tests to verify db state of these more complex / chained
scenarios.

It also marks one scenario as todo where a delete overlay
is wrongly turned into a move overlay, effectively loosing
the 'shall be deleted in live during publish' information.
This can be fixed with another patch.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 50

Show 30 more files

Review log 1729

Show 24 earlier messages
  1. Christian Kuhn uploaded patch set 1 11/03/20, 15:43

  2. TYPO3com voted on patch set 1 V -1 11/03/20, 15:55 Completed build in 11m 52s on Tue, 3 Nov, 03:55 PM Test Summary: 6 of 75452 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-710

  3. Christian Kuhn uploaded patch set 2 11/04/20, 13:23

  4. TYPO3com voted on patch set 2 V -1 11/04/20, 13:38 Completed build in 14m 17s on Wed, 4 Nov, 01:38 PM Test Summary: 6 of 74654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-714

  1. Christian Kuhn uploaded patch set 3 11/04/20, 14:12

  2. TYPO3com voted on patch set 3 V -1 11/04/20, 14:24 Completed build in 11m 41s on Wed, 4 Nov, 02:24 PM Test Summary: 6 of 75468 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-715

  3. Christian Kuhn uploaded patch set 4 11/04/20, 15:43

  4. TYPO3com voted on patch set 4 V -1 11/04/20, 15:54 Completed build in 11m 26s on Wed, 4 Nov, 03:54 PM Test Summary: 6 of 75477 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-716

  5. Christian Kuhn uploaded patch set 5 11/04/20, 16:12

  6. TYPO3com voted on patch set 5 V -1 11/04/20, 16:24 Completed build in 11m 06s on Wed, 4 Nov, 04:24 PM Test Summary: 74992 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-717

  7. Christian Kuhn uploaded patch set 6 11/04/20, 17:40

  8. TYPO3com voted on patch set 6 V -1 11/04/20, 17:54 Completed build in 13m 04s on Wed, 4 Nov, 05:54 PM Test Summary: 75022 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-720

  9. Christian Kuhn uploaded patch set 7 11/04/20, 18:07

  10. TYPO3com voted on patch set 7 V -1 11/04/20, 18:18 Completed build in 11m 16s on Wed, 4 Nov, 06:18 PM Test Summary: 75037 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-721

  11. Christian Kuhn uploaded patch set 8 11/04/20, 18:31

  12. TYPO3com voted on patch set 8 V +1 11/04/20, 18:43 Completed build in 11m 36s on Wed, 4 Nov, 06:43 PM Test Summary: 75027 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-723

  13. Christian Kuhn uploaded patch set 9 11/04/20, 19:29

  14. TYPO3com voted on patch set 9 V +1 11/04/20, 19:39 Completed build in 10m 32s on Wed, 4 Nov, 07:39 PM Test Summary: 75051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-724

  15. Christian Kuhn uploaded patch set 10 11/05/20, 13:30

  16. TYPO3com voted on patch set 10 V +1 11/05/20, 13:46 Completed build in 16m 05s on Thu, 5 Nov, 01:46 PM Test Summary: 75075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-727

  17. Christian Kuhn updated the commit message in patch set 11 11/05/20, 13:56

  18. TYPO3com voted on patch set 11 V +1 11/05/20, 14:40 Completed build in 13m 44s on Thu, 5 Nov, 02:40 PM Test Summary: 75075 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-730

  19. Benni Mack commented on patch set 11 V +1 CR +1 11/05/20, 16:04

    Great work, and thanks for adding so many tests.

    DataHandler.php:4179

    I'd say there is a cast (int) missing when reading two lines further.

    DataHandlerHook.php:1291

    in the current terms that would be a "move pointer" not a "moveOverlay" ;) but since this code is gone in v11 (for good), this does not matter at all.
  20. Christian Kuhn commented on patch set 11 11/09/20, 14:05

    DataHandler.php:4179 Reply Unresolved

    good point. done.

    DataHandlerHook.php:1291 Reply

    Ack
  21. Christian Kuhn uploaded patch set 12 11/09/20, 14:08

  22. Oli Bartsch voted on patch set 12 V +1 CR +1 11/09/20, 14:29

  23. TYPO3com voted on patch set 12 V +1 11/09/20, 14:29 Completed build in 20m 20s on Mon, 9 Nov, 02:29 PM Test Summary: 75063 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-747

  24. Benni Mack voted on patch set 12 V +2 CR +2 11/09/20, 14:32

  25. Benni Mack merged patch set 13 11/09/20, 14:32