Review 10.4 Merged

66393[BUGFIX] Provide colPos for each cell in defLangBinding view

Benni Mack CR +2 V +2 Easy +2 −2 updated 11/04/20, 08:23

Commit message

When dragging content elements in page module, the colPos
value of the dragged element is updated based on the dropped
area. A drop area is a table cell `td` in which the elements are
placed as `div`. The cell itself has the colPos set via a data
attribute. This means moving an element (`div`) to another
cell (`td`), the element gets updated with the colPos of the
new cell.

This did not work if `defLangBinding` was activated because
all elements are then assigned to separate cells which missed
the colPos information completely.

The colPos information is now added to all cells in the
`defLangBinding` view.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 11/03/20, 23:17

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/03/20, 23:29 Completed build in 11m 52s on Tue, 3 Nov, 11:29 PM Test Summary: 74976 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-712

  3. Benni Mack voted on patch set 1 V +2 CR +2 11/04/20, 08:23

  4. Benni Mack merged patch set 2 11/04/20, 08:23