Review 9.5 Merged

66394[BUGFIX] Provide colPos for each cell in defLangBinding view

Benni Mack CR +2 V +2 Easy +2 −2 updated 11/04/20, 11:57

Commit message

When dragging content elements in page module, the colPos
value of the dragged element is updated based on the dropped
area. A drop area is a table cell `td` in which the elements are
placed as `div`. The cell itself has the colPos set via a data
attribute. This means moving an element (`div`) to another
cell (`td`), the element gets updated with the colPos of the
new cell.

This did not work if `defLangBinding` was activated because
all elements are then assigned to separate cells which missed
the colPos information completely.

The colPos information is now added to all cells in the
`defLangBinding` view.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Benni Mack +2
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 914

  1. Benni Mack commented on patch set 1 11/03/20, 23:26

    Cherry Picked from branch 10.4. The following files contain Git conflicts: * typo3/sysext/backend/Classes/View/PageLayoutView.php
  2. Benni Mack commented on patch set 2 11/03/20, 23:28

    Published edit on patch set 1.
  3. Benni Mack commented on patch set 2 11/03/20, 23:28

    This change is ready for review.
  4. Oli Bartsch uploaded patch set 3 11/03/20, 23:32

  5. Oli Bartsch uploaded patch set 4 11/03/20, 23:36

  6. TYPO3com voted on patch set 1 V +1 11/03/20, 23:39 Completed build in 13m 08s on Tue, 3 Nov, 11:39 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-863

  7. Oli Bartsch uploaded patch set 5 11/03/20, 23:42

  8. TYPO3com voted on patch set 2 V +1 11/03/20, 23:45 Completed build in 15m 35s on Tue, 3 Nov, 11:45 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-864

  9. TYPO3com voted on patch set 3 V +1 11/03/20, 23:52 Completed build in 15m 55s on Tue, 3 Nov, 11:52 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-865

  10. TYPO3com voted on patch set 4 V +1 11/03/20, 23:58 Completed build in 22m 06s on Tue, 3 Nov, 11:58 PM Test Summary: 75191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-866

  11. TYPO3com voted on patch set 5 V +1 11/04/20, 00:03 Completed build in 14m 29s on Wed, 4 Nov, 12:03 AM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-867

  12. Mathias Brodala voted on patch set 5 V +1 CR +1 11/04/20, 09:38

  13. Benni Mack voted on patch set 5 V +2 CR +2 11/04/20, 11:57

  14. Benni Mack merged patch set 6 11/04/20, 11:57