66412[BUGFIX] Reimplement mod.defLangBinding for fluid-based page module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/View/BackendLayout/Grid/GridColumnItem.php+16 −0
- typo3/sysext/backend/Classes/View/Drawing/BackendLayoutRenderer.php1+73 −1
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/Column.html+1 −33
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/Grid/ColumnHeader.htmlnew+33 −0
- typo3/sysext/backend/Resources/Private/Partials/PageLayout/LanguageColumns.html+58 −10
Review log 2334
Show 79 earlier messages
-
Georg Ringer uploaded patch set 1 11/03/20, 21:48
-
TYPO3com voted on patch set 1 V -1 11/03/20, 21:49 Completed build in 37s on Tue, 3 Nov, 09:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7100
-
Georg Ringer uploaded patch set 2 11/03/20, 22:06
-
Georg Ringer uploaded patch set 3 11/04/20, 07:00
-
TYPO3com voted on patch set 3 V -1 11/04/20, 07:11 Completed build in 11m 36s on Wed, 4 Nov, 07:11 AM Test Summary: 73582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7101
-
Claus Due uploaded patch set 4 11/04/20, 22:07
-
Claus Due commented on patch set 4 11/04/20, 22:10
PS4: aligned visual with oldschool page module (grid lines, column header). Refactored the column header to a partial that we can repeatedly render w/o rendering the Column.html partial. -
Claus Due commented on patch set 4 11/04/20, 22:13
Failing build may be a false negative; I'm pretty sure I remember in the original patch I had the opposite warning that 31 spaces was expected but 32 were found. In any case, it's simple enough to fix - but would add some noise to the MR. We may want to ask the team if this formatting requirement has changed at some point? -
Claus Due uploaded patch set 5 11/04/20, 22:19
-
Claus Due commented on patch set 5 11/04/20, 22:20
PS5: implemented fix from https://review.typo3.org/c/Packages/TYPO3.CMS/+/66015 to fix drag-n-drop when def language binding is enabled. -
TYPO3com voted on patch set 4 V -1 11/04/20, 22:21 Completed build in 13m 33s on Wed, 4 Nov, 10:21 PM Test Summary: 73593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7119
-
TYPO3com voted on patch set 5 V -1 11/04/20, 22:32 Completed build in 13m 01s on Wed, 4 Nov, 10:32 PM Test Summary: 73592 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7120
-
Georg Ringer uploaded patch set 6 11/05/20, 08:42
-
TYPO3com voted on patch set 6 V +1 11/05/20, 08:54 Completed build in 12m 20s on Thu, 5 Nov, 08:54 AM Test Summary: 73593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7122
-
Georg Ringer uploaded patch set 7 11/05/20, 21:17
-
Georg Ringer commented on patch set 7 11/05/20, 21:17
This change is ready for review. -
TYPO3com voted on patch set 7 V +1 11/05/20, 21:35 Completed build in 17m 24s on Thu, 5 Nov, 09:35 PM Test Summary: 73581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7141
-
Benni Mack commented on patch set 7 11/07/20, 15:14
great stuff, but the current patch does not work for me: * In non-fluid-page module and a language in free mode, all items are shown * In fluid-page module, nothing shows up for the language -
Georg Ringer uploaded patch set 8 11/12/20, 23:01
-
Georg Ringer commented on patch set 8 11/12/20, 23:04
there is now a changed behaviour which makes still sense: in old page module having free mode, the items of non default language where just grouped (means same <tr> with the default items by their order, so 1st default with 1st element in language. now all translated records are rendered in 1st cell I see no other way than reworking the whole thing - another option would be to drop deflangbinding if non-connected mode is used on current page -
TYPO3com voted on patch set 8 V +1 11/12/20, 23:14 Completed build in 12m 40s on Thu, 12 Nov, 11:14 PM Test Summary: 73621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7282
-
Markus Klein updated the commit message in patch set 9 11/16/20, 12:35
-
TYPO3com voted on patch set 9 V +1 11/16/20, 12:46 Completed build in 11m 29s on Mon, 16 Nov, 12:46 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7339
-
Benni Mack commented on patch set 9 V +1 CR +1 11/17/20, 08:11
Still not 100% satisfied but that's due to the nature of the structure on how defLangBinding works. I think this is "better than nothing" (highly appreciate your work, Georg), let's get it in and then consider how to get this in better shape in the future. -
Benni Mack updated the commit message in patch set 10 11/17/20, 08:11
-
Benni Mack voted on patch set 10 V +1 CR +1 11/17/20, 08:12
-
TYPO3com voted on patch set 10 V -1 11/17/20, 08:24 Completed build in 11m 55s on Tue, 17 Nov, 08:24 AM Test Summary: 1 of 74174 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7371
-
TYPO3com voted on patch set 10 V +1 11/17/20, 08:35 Completed build in 35m 27s on Tue, 17 Nov, 08:35 AM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7371
-
Oli Bartsch commented on patch set 10 CR -1 11/17/20, 12:24
Will update the the patch.BackendLayoutRenderer.php:198UnresolvedPossible null pointer here. -
Oli Bartsch uploaded patch set 11 11/17/20, 12:27
-
Oli Bartsch voted on patch set 11 V +1 CR +1 11/17/20, 12:28
-
TYPO3com voted on patch set 11 V +1 11/17/20, 12:40 Completed build in 13m 20s on Tue, 17 Nov, 12:40 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7378
-
Benni Mack voted on patch set 11 V +2 CR +2 11/17/20, 14:02
-
Benni Mack merged patch set 12 11/17/20, 14:02