Review main Abandoned Breaking

66414[!!!][TASK] Remove obsolete parameter in StandardContentPreviewRenderer

Thomas Löffler CR 0 V 0 Easy +4 −8 updated 11/04/20, 10:19

Commit message

The third parameter $pageUid of function "resolveRendererFor()"
is not used and can therefore be removed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 68

  1. Thomas Löffler uploaded patch set 1 11/04/20, 08:24

  2. TYPO3com voted on patch set 1 V +1 11/04/20, 08:36 Completed build in 11m 46s on Wed, 4 Nov, 08:36 AM Test Summary: 73585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7106

  3. Oli Bartsch commented on patch set 1 V -1 11/04/20, 09:21

    Sorry but this is a breaking change if we remove a parameter from this public interface. People are using this interface in their extensions for their own previewRendererResolver.
  4. Thomas Löffler updated the commit message in patch set 2 11/04/20, 09:31

  5. TYPO3com voted on patch set 2 V +1 11/04/20, 09:42 Completed build in 10m 49s on Wed, 4 Nov, 09:42 AM Test Summary: 73585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7108

  6. Georg Ringer commented on patch set 2 CR -1 11/04/20, 10:11

    sorry after seing the code: why do you know that this parameter is not used? someone can use a custom previewrenderer which is based on the page id...?!
  7. Thomas Löffler commented on patch set 2 11/04/20, 10:19

    > Patch Set 2: Code-Review-1 > > sorry after seing the code: why do you know that this parameter is not used? someone can use a custom previewrenderer which is based on the page id...?! You're completely right, I didn't think about that. Sure. :)
  8. Thomas Löffler abandoned the change 11/04/20, 10:19