Review 10.4 Merged

66415[BUGFIX] Allow slug recreation if postModifiers are defined

Oli Bartsch CR +2 V +2 Easy +19 −4 updated 11/04/20, 09:10

Commit message

Slug fields currently only support slug recreation if the given
generator fields are directly visible in the backend. However, this
makes it impossible to recreate slugs even if some postModifiers are
defined who can take care of successful slug generation.

This commit allows slug recreation if at least one postModifier is
defined, even if the defined generator fields are not usable for
slug generation.

Therefore also EditDocumentController was adjusted to not
automatically add slug fields to columnsOnly in case postModifiers
are defined for this record.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Oli Bartsch uploaded patch set 1 11/04/20, 08:49

  2. TYPO3com voted on patch set 1 V +1 11/04/20, 09:00 Completed build in 11m 08s on Wed, 4 Nov, 09:00 AM Test Summary: 74977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-713

  3. Georg Ringer voted on patch set 1 V +2 CR +2 11/04/20, 09:10

  4. Georg Ringer merged patch set 2 11/04/20, 09:10