Review main Abandoned

66417[BUGFIX] Allow sorting by relations in combination with constraints

Albrecht Köhnlein CR 0 V 0 Easy +4 −3 updated 11/05/20, 09:16

Commit message

Check if an additional WHERE statement was created, before applying the returned
value with ->andWhere(). The original behaviour could cause a doctrine error,
if the generated WHERE statement was empty, but another WHERE statement already
was set in QueryBuilder instance.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 45

  1. Albrecht Köhnlein uploaded patch set 1 11/04/20, 15:59

  2. TYPO3com voted on patch set 1 V +1 11/04/20, 16:11 Completed build in 12m 16s on Wed, 4 Nov, 04:11 PM Test Summary: 73585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7116

  3. Georg Ringer commented on patch set 1 11/04/20, 18:23

    Can you check if you are using latest doctrine/dbal version? There have been couple of regressions and imo all fixed
  4. Albrecht Köhnlein commented on patch set 1 11/05/20, 09:16

    > Patch Set 1: > > Can you check if you are using latest doctrine/dbal version? There have been couple of regressions and imo all fixed Thanks for that hint. I just upated "doctrine/dbal" from 2.11.1 to 2.12.0 and the problem is solved. :)
  5. Albrecht Köhnlein abandoned the change 11/05/20, 09:16

    Solved by updating "doctrine/dbal" to 2.12.0