Review main Merged

66452[BUGFIX] Moving pages in workspaces updates pid correctly

Christian Kuhn CR +2 V +2 Expert +1781 −13 updated 11/09/20, 14:32

Commit message

* (v10) Moving a page that exists in live within
  workspaces multiple times does not upate the pid of
  the t3ver_state=4 overlay.

* (v10, master) Moving a page that has translations
  in workspaces multiple times does not always properly
  update the pid of the translation overlay records to the
  new location.

The patch fixes both issues and adds a series of functional
tests to verify db state of these more complex / chained
scenarios.

It also marks one scenario as todo where a delete overlay
is wrongly turned into a move overlay, effectively loosing
the 'shall be deleted in live during publish' information.
This can be fixed with another patch.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 47

Show 27 more files

Review log 1219

  1. Christian Kuhn uploaded patch set 1 11/05/20, 09:33

  2. TYPO3com voted on patch set 1 V -1 11/05/20, 09:45 Completed build in 12m 03s on Thu, 5 Nov, 09:45 AM Test Summary: 90 of 74168 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7123

  3. Christian Kuhn uploaded patch set 2 11/05/20, 11:58

  4. TYPO3com voted on patch set 2 V -1 11/05/20, 12:09 Completed build in 11m 17s on Thu, 5 Nov, 12:09 PM Test Summary: 69 of 74168 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7126

  5. Christian Kuhn uploaded patch set 3 11/05/20, 12:26

  6. TYPO3com voted on patch set 3 V -1 11/05/20, 12:37 Completed build in 11m 24s on Thu, 5 Nov, 12:37 PM Test Summary: 39 of 74168 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7127

  7. Christian Kuhn uploaded patch set 4 11/05/20, 12:44

  8. TYPO3com voted on patch set 4 V -1 11/05/20, 12:56 Completed build in 11m 32s on Thu, 5 Nov, 12:56 PM Test Summary: 73683 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7128

  9. Christian Kuhn uploaded patch set 5 11/05/20, 13:28

  10. TYPO3com voted on patch set 5 V +1 11/05/20, 13:40 Completed build in 11m 37s on Thu, 5 Nov, 01:40 PM Test Summary: 73683 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7129

  11. Christian Kuhn updated the commit message in patch set 6 11/05/20, 13:56

  12. TYPO3com voted on patch set 6 V +1 11/05/20, 14:38 Completed build in 11m 30s on Thu, 5 Nov, 02:38 PM Test Summary: 73683 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7134

  13. Benni Mack commented on patch set 6 V +1 CR +1 11/05/20, 16:03

    DataHandler.php:4106

    I'd love to have that "casted" to (int).
  14. Christian Kuhn commented on patch set 6 11/09/20, 14:05

    DataHandler.php:4106 Reply Unresolved

    good point. done.
  15. Christian Kuhn uploaded patch set 7 11/09/20, 14:06

  16. TYPO3com voted on patch set 7 V +1 11/09/20, 14:20 Completed build in 13m 06s on Mon, 9 Nov, 02:19 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7203

  17. Oli Bartsch voted on patch set 7 V +1 CR +1 11/09/20, 14:26

  18. Benni Mack voted on patch set 7 V +2 CR +2 11/09/20, 14:32

  19. Benni Mack merged patch set 8 11/09/20, 14:32