Review main Merged

66453[BUGFIX] Fix workspace select / deselect all buttons

Oli Bartsch CR +2 V +2 Easy +9 −13 updated 11/05/20, 15:59

Commit message

The "select all" and "deselect all" buttons in the "Send to stage"
modal in workspaces are now proper button tags.

This also allowed to remove the superfluous preventDefault()
call in JavaScript.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Michael Telgkamp +1
  • Verified V +2 Done
    • Benni Mack +2
    • Michael Telgkamp +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/05/20, 10:06

  2. Oli Bartsch wrote 11/05/20, 10:06

    Topic set to a11y
  3. TYPO3com voted on patch set 1 V +1 11/05/20, 10:17 Completed build in 10m 51s on Thu, 5 Nov, 10:17 AM Test Summary: 73593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7124

  4. Michael Telgkamp commented on patch set 1 V +1 CR +1 11/05/20, 15:41

    Thank you for this accessibility improvement.
  5. Benni Mack voted on patch set 1 V +2 CR +2 11/05/20, 15:59

  6. Benni Mack merged patch set 2 11/05/20, 15:59