6650[BUGFIX] RTE not loading in IE when content css file does not exist
Commit message
Review
-
Code review CR +2
- Stanislas Rolland +2
-
Verified V +2
- Stanislas Rolland +2
Issues 1
Files 1
Review log 15
-
Stanislas Rolland merged patch set 1 12/16/11, 20:31
-
Stefan Neufeind commented on patch set 1 12/16/11, 20:31
Looks good to me, but someone else must approve got hit by this one lately. nice catch -
Stanislas Rolland uploaded patch set 3 12/16/11, 20:31
-
Stanislas Rolland commented on patch set 3 V 0 12/16/11, 20:31
by team member; Looks good to me, approved -
Markus Klein commented on patch set 3 12/16/11, 20:31
@Simon: That's why https://review.typo3.org/7314 is on its way. -
Oliver Hader uploaded patch set 2 12/16/11, 20:31
-
Oliver Hader commented on patch set 2 12/16/11, 20:31
Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:1, R:1 from Helmut Hummel <typo3@helmut-hummel.de> -
Helmut Hummel commented on patch set 1 12/16/11, 20:31
Verified; Looks good to me, but someone else must approve -
Helmut Hummel commented on patch set 2 12/16/11, 20:31
Verified; Looks good to me, but someone else must approve -
Simon Schaufelberger commented on patch set 3 12/16/11, 20:31
sorry guys, did anyone of you *really* test this? if ($fileName) { $filename = $this->getFullFileName($fileName); must be: $fileName = $this->getFullFileName($fileName);class.tx_rtehtmlarea_base.php:453this variable is not used again later because the "n" must be "N" -
Simon Schaufelberger commented on patch set 3 12/16/11, 20:31
(1 inline comment) i know, i have seen it but a bug should not enter the core if the code is REALLY verified - not by just looking the diff in gerrit. -
Mr. Jenkins commented on patch set 1 12/16/11, 20:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2392/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/16/11, 20:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2670/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/16/11, 20:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2759/ : SUCCESS -
Stanislas Rolland commented on patch set 3 12/16/11, 20:31
You are most welcome to REALLY verify this change: http://review.typo3.org/7314