Review main Merged

6650[BUGFIX] RTE not loading in IE when content css file does not exist

Stanislas Rolland CR +2 V +2 Easy +21 −6 updated 06/03/13, 20:49

Commit message

Solution: Fallback to the default contentCSS file when the file
specified in Page TS Config does not exist or is of zero size.

Review

  • Code review CR +2
    • Stanislas Rolland +2
  • Verified V +2
    • Stanislas Rolland +2

Issues 1

Files 1

Review log 15

  1. Stanislas Rolland merged patch set 1 12/16/11, 20:31

  2. Stefan Neufeind commented on patch set 1 12/16/11, 20:31

    Looks good to me, but someone else must approve got hit by this one lately. nice catch
  3. Stanislas Rolland uploaded patch set 3 12/16/11, 20:31

  4. Stanislas Rolland commented on patch set 3 V 0 12/16/11, 20:31

    by team member; Looks good to me, approved
  5. Markus Klein commented on patch set 3 12/16/11, 20:31

    @Simon: That's why https://review.typo3.org/7314 is on its way.
  6. Oliver Hader uploaded patch set 2 12/16/11, 20:31

  7. Oliver Hader commented on patch set 2 12/16/11, 20:31

    Verified; Looks good to me, but someone else must approve Rebasing to master V:1, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:1, R:1 from Helmut Hummel <typo3@helmut-hummel.de>
  8. Helmut Hummel commented on patch set 1 12/16/11, 20:31

    Verified; Looks good to me, but someone else must approve
  9. Helmut Hummel commented on patch set 2 12/16/11, 20:31

    Verified; Looks good to me, but someone else must approve
  10. Simon Schaufelberger commented on patch set 3 12/16/11, 20:31

    sorry guys, did anyone of you *really* test this? if ($fileName) { $filename = $this->getFullFileName($fileName); must be: $fileName = $this->getFullFileName($fileName);

    class.tx_rtehtmlarea_base.php:453

    this variable is not used again later because the "n" must be "N"
  11. Simon Schaufelberger commented on patch set 3 12/16/11, 20:31

    (1 inline comment) i know, i have seen it but a bug should not enter the core if the code is REALLY verified - not by just looking the diff in gerrit.
  12. Mr. Jenkins commented on patch set 1 12/16/11, 20:31

  13. Mr. Jenkins commented on patch set 2 12/16/11, 20:31

  14. Mr. Jenkins commented on patch set 3 12/16/11, 20:31

  15. Stanislas Rolland commented on patch set 3 12/16/11, 20:31

    You are most welcome to REALLY verify this change: http://review.typo3.org/7314