Review TYPO3_4-5 Merged

6652[BUGFIX] RTE not loading in IE when content css file does not exist

Stanislas Rolland CR +2 V +2 Easy +20 −6 updated 06/03/13, 20:49

Commit message

Solution: Fallback to the default contentCSS file when the file
specified in Page TS Config does not exist or has zero file size.

Review

  • Code review CR +2
    • Stanislas Rolland +2
  • Verified V +2
    • Stanislas Rolland +2

Issues 1

Files 1

Review log 7

  1. Stefan Neufeind commented on patch set 1 12/16/11, 03:16

    Looks good to me, but someone else must approve
  2. Stanislas Rolland uploaded patch set 3 12/16/11, 03:16

  3. Stanislas Rolland commented on patch set 3 V 0 12/16/11, 03:16

    by team member; Looks good to me, approved
  4. Oliver Hader uploaded patch set 2 12/16/11, 03:16

  5. Oliver Hader commented on patch set 2 12/16/11, 03:16

    Verified; Looks good to me, but someone else must approve Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:1, R:1 as a summary of previous scores (limited to [-1;+1]) V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:1, R:1 from Helmut Hummel <typo3@helmut-hummel.de>
  6. Helmut Hummel commented on patch set 1 12/16/11, 03:16

    Verified; Looks good to me, but someone else must approve Thanks. This fixes the issue when the content CSS does not exist. htmlarea (in 4.5 branch) still fails to load when the file exists but is empty, but this can be tackled in another ticket. Btw. I just realized, that htmlarea version of master/ 4.6 loads in any case in IE, but gives the error message "The stylesheets could not be parsed. Reported error: Empty rules and imports arrays of styleSheets" This would be fine for me. Probably this behaviour can be adapted for 4.5 also.
  7. Stanislas Rolland merged patch set 3 12/16/11, 03:16