Review 10.4 Merged

66526[BUGFIX] Fix workspace select / deselect all buttons

Michael Telgkamp CR +2 V +2 Easy +9 −13 updated 11/06/20, 10:10

Commit message

The "select all" and "deselect all" buttons in the "Send to stage"
modal in workspaces are now proper button tags.

This also allowed to remove the superfluous preventDefault()
call in JavaScript.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 68

  1. Michael Telgkamp uploaded patch set 1 11/06/20, 09:37

  2. Benni Mack updated the commit message in patch set 2 11/06/20, 09:42

  3. TYPO3com voted on patch set 1 V +1 11/06/20, 09:49 Completed build in 11m 56s on Fri, 6 Nov, 09:49 AM Test Summary: 74983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-732

  4. TYPO3com voted on patch set 2 V +1 11/06/20, 09:54 Completed build in 11m 21s on Fri, 6 Nov, 09:54 AM Test Summary: 74985 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-733

  5. Michael Telgkamp wrote 11/06/20, 10:07

    Topic a11y removed
  6. Michael Telgkamp wrote 11/06/20, 10:07

    Topic set to a11y-10.4
  7. Benni Mack voted on patch set 2 V +2 CR +2 11/06/20, 10:09

  8. Benni Mack merged patch set 3 11/06/20, 10:10