Review 10.4 Merged

66527[BUGFIX] Allow keyboard usage of file upload dropzone

Michael Telgkamp CR +2 V +2 Easy +17 −6 updated 11/06/20, 10:09

Commit message

The dropzone for file uploads now uses two <button> tags
instead of <div> tags. One for the dropzone itself and
the other one for the close button.

The dropzone button now has got an `aria-labelledby`
attribute pointing to the dropzone title. The close
button got an `aria-label` attribute. Both to support
screen readers.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 56

  1. Michael Telgkamp uploaded patch set 1 11/06/20, 09:45

  2. TYPO3com voted on patch set 1 V +1 11/06/20, 09:59 Completed build in 11m 19s on Fri, 6 Nov, 09:58 AM Test Summary: 74985 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-734

  3. Michael Telgkamp wrote 11/06/20, 10:07

    Topic a11y removed
  4. Michael Telgkamp wrote 11/06/20, 10:07

    Topic set to a11y-10.4
  5. Benni Mack voted on patch set 1 V +2 CR +2 11/06/20, 10:09

  6. Benni Mack merged patch set 2 11/06/20, 10:09