66532[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:extbase
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- TYPO3com +1 CI
Issues 1
Files 32
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php+5 −1
- typo3/sysext/extbase/Classes/Mvc/View/NotFoundView.php+1 −0
- typo3/sysext/extbase/Classes/Object/Container/Container.php+7 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMap.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php+3 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/AndInterface.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Qom/OrInterface.php+2 −2
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbQueryParser.php+15 −25
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+4 −5
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyLoadingProxy.php+7 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/LazyObjectStorage.php+8 −8
- typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php+10 −8
- typo3/sysext/extbase/Classes/Property/TypeConverter/AbstractFileFolderConverter.php+1 −1
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfiguration.php+1 −1
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+1 −0
- typo3/sysext/extbase/Classes/SignalSlot/Dispatcher.php+8 −5
- typo3/sysext/extbase/Classes/Utility/ExtensionUtility.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/AlphanumericValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/BooleanValidator.php+3 −3
- typo3/sysext/extbase/Classes/Validation/Validator/DateTimeValidator.php+1 −1
Show 12 more files
- typo3/sysext/extbase/Classes/Validation/Validator/EmailAddressValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/FloatValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/IntegerValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/NotEmptyValidator.php+4 −4
- typo3/sysext/extbase/Classes/Validation/Validator/NumberRangeValidator.php+2 −2
- typo3/sysext/extbase/Classes/Validation/Validator/NumberValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/RegularExpressionValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/StringLengthValidator.php+4 −3
- typo3/sysext/extbase/Classes/Validation/Validator/StringValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/TextValidator.php+1 −1
- typo3/sysext/extbase/Classes/Validation/Validator/UrlValidator.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbQueryParserTest.php+0 −66
Review log 912
-
Benni Mack commented on patch set 1 11/05/20, 19:54
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Validation/Validator/RegularExpressionValidator.php -
TYPO3com voted on patch set 1 V -1 11/05/20, 19:55 Completed build in 25s on Thu, 5 Nov, 07:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-731
-
Daniel Goerz commented on patch set 1 CR -2 11/05/20, 22:31
I am gonna take care -
Daniel Goerz uploaded patch set 2 11/06/20, 09:52
-
Daniel Goerz uploaded patch set 3 11/06/20, 09:53
-
TYPO3com voted on patch set 2 V -1 11/06/20, 10:12 Completed build in 19m 16s on Fri, 6 Nov, 10:12 AM Test Summary: 38192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-735
-
Daniel Goerz voted on patch set 3 CR 0 11/06/20, 10:47
-
Benni Mack commented on patch set 3 11/06/20, 10:48
This change is ready for review. -
Oliver Klee voted on patch set 3 CR +1 11/06/20, 11:42
-
TYPO3com voted on patch set 3 V +1 11/06/20, 16:06 Completed build in 12m 16s on Fri, 6 Nov, 04:06 PM Test Summary: 74973 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-740
-
Benni Mack voted on patch set 3 V +2 CR +2 11/07/20, 08:54
-
Benni Mack merged patch set 4 11/07/20, 08:54