Review 10.4 Merged

66532[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:extbase

Benni Mack CR +2 V +2 Hard +102 −156 updated 11/07/20, 08:54

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 32

Show 12 more files

Review log 912

  1. Benni Mack commented on patch set 1 11/05/20, 19:54

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Validation/Validator/RegularExpressionValidator.php
  2. TYPO3com voted on patch set 1 V -1 11/05/20, 19:55 Completed build in 25s on Thu, 5 Nov, 07:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-731

  3. Daniel Goerz commented on patch set 1 CR -2 11/05/20, 22:31

    I am gonna take care
  4. Daniel Goerz uploaded patch set 2 11/06/20, 09:52

  5. Daniel Goerz uploaded patch set 3 11/06/20, 09:53

  6. TYPO3com voted on patch set 2 V -1 11/06/20, 10:12 Completed build in 19m 16s on Fri, 6 Nov, 10:12 AM Test Summary: 38192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-735

  7. Daniel Goerz voted on patch set 3 CR 0 11/06/20, 10:47

  8. Benni Mack commented on patch set 3 11/06/20, 10:48

    This change is ready for review.
  9. Oliver Klee voted on patch set 3 CR +1 11/06/20, 11:42

  10. TYPO3com voted on patch set 3 V +1 11/06/20, 16:06 Completed build in 12m 16s on Fri, 6 Nov, 04:06 PM Test Summary: 74973 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-740

  11. Benni Mack voted on patch set 3 V +2 CR +2 11/07/20, 08:54

  12. Benni Mack merged patch set 4 11/07/20, 08:54