Review 10.4 Merged

66534[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend

Daniel Goerz CR +2 V +2 Normal +54 −47 updated 11/13/20, 13:16

Commit message

This patch fixes incompatible type usage in function arguments
and is preparatory work for introducing native type hints and
strict mode in all core files.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 1016

  1. Daniel Goerz commented on patch set 1 11/06/20, 10:51

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php
  2. TYPO3com voted on patch set 1 V -1 11/06/20, 10:53 Completed build in 01m 01s on Fri, 6 Nov, 10:53 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-738

  3. Daniel Goerz uploaded patch set 2 11/06/20, 10:54

  4. Benni Mack commented on patch set 2 11/07/20, 08:54

    This change is ready for review.
  5. TYPO3com commented on patch set 2 11/07/20, 08:57 Completed build in 28s on Sat, 7 Nov, 08:57 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-741

  6. Oliver Klee commented on patch set 2 CR -1 11/07/20, 10:41

    StandardContentPreviewRenderer.php:158

    We still have the merge conflict markers here.
  7. Daniel Goerz uploaded patch set 3 11/12/20, 16:59

  8. Daniel Goerz commented on patch set 3 11/12/20, 17:00

    StandardContentPreviewRenderer.php:158 Reply

    Done
  9. TYPO3com voted on patch set 3 V -1 11/12/20, 17:10 Completed build in 11m 00s on Thu, 12 Nov, 05:10 PM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-767

  10. TYPO3com commented on patch set 3 11/12/20, 17:22 Completed build in 34m 07s on Thu, 12 Nov, 05:22 PM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-767

  11. Daniel Goerz rebased onto patch set 4 11/12/20, 18:15

  12. TYPO3com commented on patch set 3 11/12/20, 18:17 Completed build in 1h 52m 14s on Thu, 12 Nov, 06:17 PM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-767

  13. TYPO3com voted on patch set 4 V +1 11/12/20, 18:27 Completed build in 11m 52s on Thu, 12 Nov, 06:27 PM Test Summary: 75066 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-773

  14. Oliver Klee voted on patch set 4 CR +1 11/12/20, 19:15

  15. Daniel Goerz voted on patch set 4 V +2 CR +2 11/13/20, 13:16

  16. Daniel Goerz merged patch set 5 11/13/20, 13:16