66534[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:backend
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oliver Klee +1
-
Verified V +2 Done
- Daniel Goerz +2
- TYPO3com +1 CI
Issues 1
Files 16
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+1 −1
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+1 −1
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php+8 −8
- typo3/sysext/backend/Classes/Command/LockBackendCommand.php+1 −0
- typo3/sysext/backend/Classes/Command/ResetPasswordCommand.php+2 −0
- typo3/sysext/backend/Classes/ContextMenu/ItemProviders/RecordProvider.php+1 −1
- typo3/sysext/backend/Classes/Domain/Repository/TableManualRepository.php+2 −0
- typo3/sysext/backend/Classes/History/RecordHistory.php+2 −2
- typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php2+3 −3
- typo3/sysext/backend/Classes/Preview/StandardPreviewRendererResolver.php+1 −0
- typo3/sysext/backend/Classes/Template/Components/MetaInformation.php+1 −1
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+2 −2
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+26 −26
- typo3/sysext/backend/Classes/View/PageTreeView.php+1 −0
- typo3/sysext/backend/Classes/FrontendBackendUserAuthentication.php+1 −1
Review log 1016
-
Daniel Goerz commented on patch set 1 11/06/20, 10:51
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Preview/StandardContentPreviewRenderer.php -
TYPO3com voted on patch set 1 V -1 11/06/20, 10:53 Completed build in 01m 01s on Fri, 6 Nov, 10:53 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-738
-
Daniel Goerz uploaded patch set 2 11/06/20, 10:54
-
Benni Mack commented on patch set 2 11/07/20, 08:54
This change is ready for review. -
TYPO3com commented on patch set 2 11/07/20, 08:57 Completed build in 28s on Sat, 7 Nov, 08:57 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-741
-
Oliver Klee commented on patch set 2 CR -1 11/07/20, 10:41
StandardContentPreviewRenderer.php:158We still have the merge conflict markers here. -
Daniel Goerz uploaded patch set 3 11/12/20, 16:59
-
Daniel Goerz commented on patch set 3 11/12/20, 17:00
StandardContentPreviewRenderer.php:158ReplyDone -
TYPO3com voted on patch set 3 V -1 11/12/20, 17:10 Completed build in 11m 00s on Thu, 12 Nov, 05:10 PM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-767
-
TYPO3com commented on patch set 3 11/12/20, 17:22 Completed build in 34m 07s on Thu, 12 Nov, 05:22 PM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-767
-
Daniel Goerz rebased onto patch set 4 11/12/20, 18:15
-
TYPO3com commented on patch set 3 11/12/20, 18:17 Completed build in 1h 52m 14s on Thu, 12 Nov, 06:17 PM Test Summary: 3 of 75551 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-767
-
TYPO3com voted on patch set 4 V +1 11/12/20, 18:27 Completed build in 11m 52s on Thu, 12 Nov, 06:27 PM Test Summary: 75066 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-773
-
Oliver Klee voted on patch set 4 CR +1 11/12/20, 19:15
-
Daniel Goerz voted on patch set 4 V +2 CR +2 11/13/20, 13:16
-
Daniel Goerz merged patch set 5 11/13/20, 13:16