66552[BUGFIX] Add pid restriction when getting previousLocalizedRecord
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 2
Files 17
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentAfterMovedContent.csvnew+35 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+10 −0
- typo3/sysext/core/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+23 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/localizeContentAfterMovedContent.csvnew+41 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/DataSet/localizeContentAfterMovedInLiveContent.csvnew+40 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Discard/ActionTest.php+20 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentAfterMovedContent.csvnew+43 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/DataSet/localizeContentAfterMovedInLiveContent.csvnew+42 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Modify/ActionTest.php+18 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/localizeContentAfterMovedContent.csvnew+43 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/DataSet/localizeContentAfterMovedInLiveContent.csvnew+42 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/Publish/ActionTest.php+20 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/localizeContentAfterMovedContent.csvnew+42 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/DataSet/localizeContentAfterMovedInLiveContent.csvnew+42 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/PublishAll/ActionTest.php+20 −0
- typo3/sysext/workspaces/Tests/Functional/DataHandling/Regular/AbstractActionTestCase.php+24 −0
Review log 3054
Show 1829 earlier messages
-
Philipp Parzer uploaded patch set 1 11/06/20, 11:43
-
TYPO3com voted on patch set 1 V +1 11/06/20, 11:55 Completed build in 11m 48s on Fri, 6 Nov, 11:55 AM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7144
-
Christian Kuhn commented on patch set 1 11/09/20, 09:32
This one should probably be accompanied by functional tests: I guess ext:core/Tests/Functional/DataHandling/Regular/Modify might have something fitting already that just misses the l10n_source field coverage in .csv files to show the difference before/after, or another tests similar to existing tests that cover language field behavior could be added. -
Philipp Parzer uploaded patch set 2 11/12/20, 14:57
-
TYPO3com voted on patch set 2 V +1 11/12/20, 15:10 Completed build in 12m 12s on Thu, 12 Nov, 03:10 PM Test Summary: 73626 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7271
-
Andreas Kienast updated the commit message in patch set 3 11/19/20, 07:04
-
TYPO3com voted on patch set 3 V +1 11/19/20, 07:16 Completed build in 11m 53s on Thu, 19 Nov, 07:16 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7411
-
Denis Mir commented on patch set 3 V +1 CR +1 11/19/20, 07:47
Works now as expected. -
Markus Klein commented on patch set 3 11/19/20, 15:20
Unresolved
only master? v10 is fine? -
Denis Mir commented on patch set 3 CR 0 11/19/20, 16:15
Nope 10LTS is broken as well! -
Philipp Parzer updated the commit message in patch set 4 11/20/20, 06:47
-
Denis Mir commented on patch set 4 V +1 CR +1 11/20/20, 06:54
Looks fine now for me. -
TYPO3com voted on patch set 4 V +1 11/20/20, 07:00 Completed build in 12m 20s on Fri, 20 Nov, 07:00 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7435
-
Markus Klein voted on patch set 4 V +1 CR +1 11/27/20, 22:48
-
Andreas Kienast voted on patch set 4 CR +1 02/05/21, 07:04
-
Andreas Kienast rebased onto patch set 5 02/05/21, 07:12
-
TYPO3com voted on patch set 5 V -1 02/05/21, 07:21 Completed build in 08m 21s on Fri, 5 Feb, 07:21 AM Test Summary: 4 of 32829 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9273
-
core-ci voted on patch set 5 V -1 02/05/21, 07:24 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/391
-
Andreas Kienast uploaded patch set 6 02/05/21, 07:32
-
Andreas Kienast commented on patch set 6 02/05/21, 07:32
@lolli can you please check whether the changed sys_refindex assertions in localizeContentAfterMovedContent.csv are legit? -
TYPO3com voted on patch set 6 V +1 02/05/21, 07:38 Completed build in 06m 12s on Fri, 5 Feb, 07:38 AM Test Summary: 32588 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9275
-
core-ci voted on patch set 6 V +1 02/05/21, 07:43 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/393
-
Christian Kuhn commented on patch set 6 CR -1 03/24/21, 14:24
working on it. -
Christian Kuhn uploaded patch set 7 03/24/21, 14:41
-
Christian Kuhn commented on patch set 7 CR -1 03/24/21, 14:42
rebased for now. -
TYPO3com voted on patch set 7 V -1 03/24/21, 14:49 Completed build in 07m 31s on Wed, 24 Mar, 02:49 PM Test Summary: 3 of 33035 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10327
-
core-ci voted on patch set 7 V -1 03/24/21, 14:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1807
-
Christian Kuhn uploaded patch set 8 03/24/21, 15:14
-
TYPO3com voted on patch set 8 V +1 03/24/21, 15:22 Completed build in 07m 55s on Wed, 24 Mar, 03:22 PM Test Summary: 32919 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10329
-
core-ci voted on patch set 8 V +1 03/24/21, 15:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1809
-
Christian Kuhn uploaded patch set 9 03/24/21, 16:06
-
Christian Kuhn commented on patch set 9 CR -1 03/24/21, 16:08
ok ... now let's see what happens with this scenario in workspaces! -
TYPO3com voted on patch set 9 V +1 03/24/21, 16:13 Completed build in 06m 13s on Wed, 24 Mar, 04:13 PM Test Summary: 32919 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10331
-
core-ci voted on patch set 9 V +1 03/24/21, 16:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1812
-
Christian Kuhn uploaded patch set 10 03/24/21, 16:56
-
TYPO3com voted on patch set 10 V -1 03/24/21, 16:57 Completed build in 21s on Wed, 24 Mar, 04:57 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10332
-
core-ci voted on patch set 10 V -1 03/24/21, 16:58 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1813
-
Christian Kuhn uploaded patch set 11 03/24/21, 17:37
-
Christian Kuhn updated the commit message in patch set 12 03/24/21, 17:38
-
Christian Kuhn updated the commit message in patch set 13 03/24/21, 17:40
-
TYPO3com voted on patch set 11 V +1 03/24/21, 17:44 Completed build in 06m 45s on Wed, 24 Mar, 05:44 PM Test Summary: 32943 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10333
-
TYPO3com voted on patch set 12 V +1 03/24/21, 17:45 Completed build in 06m 37s on Wed, 24 Mar, 05:45 PM Test Summary: 32943 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10334
-
Christian Kuhn updated the commit message in patch set 14 03/24/21, 17:46
-
TYPO3com voted on patch set 13 V +1 03/24/21, 17:46 Completed build in 06m 33s on Wed, 24 Mar, 05:46 PM Test Summary: 32943 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10335
-
core-ci voted on patch set 11 V +1 03/24/21, 17:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1814
-
TYPO3com voted on patch set 14 V +1 03/24/21, 17:52 Completed build in 06m 44s on Wed, 24 Mar, 05:52 PM Test Summary: 32943 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10336
-
core-ci voted on patch set 12 V +1 03/24/21, 17:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1815
-
core-ci voted on patch set 13 V +1 03/24/21, 17:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1816
-
core-ci voted on patch set 14 V +1 03/24/21, 18:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1817
-
Christian Kuhn voted on patch set 14 V +1 CR +1 03/25/21, 11:51
-
Oli Bartsch voted on patch set 14 V +1 CR +1 03/25/21, 13:18
-
Benni Mack voted on patch set 14 V +2 CR +2 03/25/21, 15:06
-
Christian Kuhn voted on patch set 14 V +2 CR +2 03/25/21, 16:52
-
Christian Kuhn merged patch set 15 03/25/21, 16:52