66556[BUGFIX] Allow "copy" action even if the user does not have "edit" permission
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Marcus Schwemer +1
- Benni Mack +1
-
Verified V +2 Done
- Richard Haeser +2
- Marcus Schwemer +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1819
-
Dmitry Dulepov uploaded patch set 1 11/06/20, 15:01
-
TYPO3com voted on patch set 1 V +1 11/06/20, 15:22 Completed build in 19m 01s on Fri, 6 Nov, 03:22 PM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7154
-
Oli Bartsch commented on patch set 1 V -1 11/06/20, 16:51
I wonder what the benefit would be, having the copy action visible in the context menu while the user still can't past the copied record then as this does also require EDIT permission? Furthermore this check does also evaluate stuff like readOnly, adminOnly, editlock, select/modify table permissions, and so on. Removing the whole check is therefore not reasonable IMO. -
Dmitry Dulepov commented on patch set 1 11/06/20, 16:55
> Patch Set 1: Verified-1 > > I wonder what the benefit would be, having the copy action visible in the context menu while the user still can't past the copied record then as this does also require EDIT permission? The user can paste copied elements to pages where (s)he has edit permissions. In our case there are template pages with content elements that cannot be edited by non-admin user (because they are templates). Users can copy elements from these read-only pages and paste into normal pages. This worked in v8 but does not work since v9. So it is a valid use case. > Furthermore this check does also evaluate stuff like readOnly, adminOnly, editlock, select/modify table permissions, and so on. Removing the whole check is therefore not reasonable IMO. Yes, this is correct. These checks are not needed for read-only actions like "copy". They would be needed for "cut" or "paste" but not for "copy". -
Oli Bartsch commented on patch set 1 V 0 11/06/20, 17:05
> Patch Set 1: > > > Patch Set 1: Verified-1 > > > > I wonder what the benefit would be, having the copy action visible in the context menu while the user still can't past the copied record then as this does also require EDIT permission? > > The user can paste copied elements to pages where (s)he has edit permissions. In our case there are template pages with content elements that cannot be edited by non-admin user (because they are templates). Users can copy elements from these read-only pages and paste into normal pages. This worked in v8 but does not work since v9. So it is a valid use case. > > > Furthermore this check does also evaluate stuff like readOnly, adminOnly, editlock, select/modify table permissions, and so on. Removing the whole check is therefore not reasonable IMO. > > Yes, this is correct. These checks are not needed for read-only actions like "copy". They would be needed for "cut" or "paste" but not for "copy". Thanks for the explanation. Seems like this got introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/63696 -
Dmitry Dulepov commented on patch set 1 11/06/20, 17:14
> Thanks for the explanation. Seems like this got introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/63696 Thanks! Hopefully Benny will look into it and comment. I tested my change in the List module on the page without "edit content" permission on the tt_content record: copying works fine and I cannot reproduce the issue, which is described in that change request. There is no spinning wheel, content element properly copied and can be pasted to other pages. Therefore that change does not seem necessary. -
Dmitry Dulepov commented on patch set 1 01/14/21, 11:55
Unresolved
@Benni, could you have a quick look, please? :) Thanks! -
Richard Haeser commented on patch set 1 01/19/21, 13:20
IMHO this is a fine fix. Some small comments on the commit message though. And of course, maybe we should wait for benni's opinion ;-)However I love it when "users" make it possible to fix core-bugs, I have never seen credits in our commit messagesIMHO this is not a priority fix and should therefor not target v9. -
Dmitry Dulepov commented on patch set 1 01/19/21, 13:28
Reply
I did saw them and I usually put them because it makes sense to thank companies, who contribute their time and effort to making TYPO3 better. In my opinion this actually stimulates TYPO3 agencies and companies to work more on TYPO3 and contribute. Given the recent call of T3A for agencies to spend more time on TYPO3, I think it is not an issue to make attribution. So I would insist to keep it. You do not have to :) But I do.Reply
Thanks for your opinion but it is purely "imho" because we have a totally different "imho" on this and we need this bug fix. -
Richard Haeser commented on patch set 1 01/19/21, 13:37
Reply
I like the idea to give those companies credits, but just not sure if commit messages are the right location. Companies that do sponsor me fixing bugs get a spot on my website as sponsor, but maybe there should be a more visible location for those sponsors and not in a commit message or on a personal website of a developer.Reply
I always checkout when a bug is found and how much people commented or watched the issue on forge to define if this is a priority bugfix. I have fixes in v9 myself as well, but I apply them as a patch. In the end: this kind of things needs to be decided by Benni and I'm totally fine by every decision. This is a small fix which should not "harm" other v9 users. -
Dmitry Dulepov commented on patch set 1 01/19/21, 13:41
Reply
Please, explain why do you think this bug fix harms anybody. This is quite a serious statement and I would like to know more information about how this harms other users. Also I am puzzled why would somebody withhold a fix for a bug if he has one. I would definitely go and provide it to the community at once instead of holding it for myself only. But this is everybody's own choice of course, whether to submit a fix or withhold it... -
Richard Haeser commented on patch set 1 01/19/21, 13:44
Reply
Maybe wrong wording, but I ment this fix will not harm anybody ;-) -
Dmitry Dulepov commented on patch set 1 01/19/21, 13:45
Reply
Ah, thanks :) I was worried that we did something wrong here :) Sorry for the confusion! 👍 -
Marcus Schwemer commented on patch set 1 V +1 02/23/21, 08:17
Reply
On the one side I can understand this and agree that there may be a need for a higher visibility for worktime sponsors. On the other side, there is more worktime than the fix itself: One customer paid us for creating the ticket, another one payes now for testing. Then there are volunteers testing and reviewing the code. All provide a resonable amount of work to be mentioned. This topic of gaining visibility is also tackled by TYPO3 karma. More information here: https://typo3.org/article/my-typo3-org-becomes-my-typo3 To make it short: I would like to see the sponsorship line removed. -
Dmitry Dulepov commented on patch set 1 02/23/21, 08:28
Marcus, I am with TYPO3 core development since 2003. Please, don't tell me about visibility. This is completely unrelated to the patch and I see it as offtopic. You are absolutely free and within your rights to skip sponsor information in your own patches and I will respect your decision there. As the author of this patch I would like to keep this line. And I hope you will respect my decision as well. The final decision is with the person, who is going to merge it. Thanks to everybody. -
Benni Mack commented on patch set 1 V +1 CR +1 04/27/21, 19:12
Fine with me, also for 9.5 -
Marcus Schwemer voted on patch set 1 CR +1 04/28/21, 11:45
-
Richard Haeser voted on patch set 1 V +2 CR +2 04/28/21, 11:56
-
Richard Haeser merged patch set 2 04/28/21, 11:56