Review 10.4 Merged

66561[TASK] Upgrade typo3/phar-stream-wrapper to v3.1.6

Oliver Hader CR +2 V +2 Easy +12 −11 updated 11/07/20, 12:26

Commit message

PHP versions 8.0-RC1, 7.4.12, 7.3.24 introduced a different behavior
for `stream_wrapper_restore()` and would throw a PHP notice which is
mitigated with this phar stream wrapper release.

see https://github.com/TYPO3/phar-stream-wrapper/releases/tag/v3.1.6

composer require typo3/phar-stream-wrapper:^3.1.6

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Helmut Hummel +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 69

  1. Oliver Hader uploaded patch set 1 11/07/20, 11:16

  2. Oliver Hader commented on patch set 1 CR -1 11/07/20, 11:20

    composer.lock has too many changes. I'm not sure about implications when switching to v2 of the API.
  3. TYPO3com voted on patch set 1 V -1 11/07/20, 11:31 Completed build in 14m 25s on Sat, 7 Nov, 11:31 AM Test Summary: 74146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-743

  4. Helmut Hummel uploaded patch set 2 11/07/20, 11:59

  5. TYPO3com voted on patch set 1 V +1 11/07/20, 12:00 Completed build in 57m 28s on Sat, 7 Nov, 12:00 PM Test Summary: 74971 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-743

  6. TYPO3com voted on patch set 2 V +1 11/07/20, 12:11 Completed build in 12m 23s on Sat, 7 Nov, 12:11 PM Test Summary: 74973 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-745

  7. Helmut Hummel voted on patch set 2 V +1 CR +1 11/07/20, 12:17

  8. Oliver Hader voted on patch set 2 V +2 CR +2 11/07/20, 12:26

  9. Oliver Hader merged patch set 3 11/07/20, 12:26