Review 9.5 Merged

66562[TASK] Upgrade typo3/phar-stream-wrapper to v3.1.6

Oliver Hader CR +2 V +2 Easy +12 −11 updated 11/07/20, 12:37

Commit message

PHP versions 8.0-RC1, 7.4.12, 7.3.24 introduced a different behavior
for `stream_wrapper_restore()` and would throw a PHP notice which is
mitigated with this phar stream wrapper release.

see https://github.com/TYPO3/phar-stream-wrapper/releases/tag/v3.1.6

composer require typo3/phar-stream-wrapper:^3.1.6

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Helmut Hummel +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 710

  1. Oliver Hader uploaded patch set 1 11/07/20, 11:19

  2. Oliver Hader commented on patch set 1 CR -1 11/07/20, 11:20

    composer.lock has too many changes. I'm not sure about implications when switching to v2 of the API.
  3. TYPO3com voted on patch set 1 V +1 11/07/20, 11:36 Completed build in 17m 07s on Sat, 7 Nov, 11:36 AM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-869

  4. Helmut Hummel uploaded patch set 2 11/07/20, 12:12

  5. Helmut Hummel uploaded patch set 3 11/07/20, 12:13

  6. Helmut Hummel voted on patch set 3 V +1 CR +1 11/07/20, 12:18

  7. TYPO3com voted on patch set 2 V -1 11/07/20, 12:18 Completed build in 35s on Sat, 7 Nov, 12:18 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-872

  8. TYPO3com voted on patch set 3 V +1 11/07/20, 12:37 Completed build in 19m 01s on Sat, 7 Nov, 12:37 PM Test Summary: 75190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-873

  9. Oliver Hader voted on patch set 3 V +2 CR +2 11/07/20, 12:37

  10. Oliver Hader merged patch set 4 11/07/20, 12:37