Review main Merged

66564[FEATURE] Introduce ForwardResponse for extbase

Alexander Schnitzler CR +2 V +2 Hard +445 −97 updated 12/05/20, 20:51

Commit message

This patch introduces a PSR-7 compatible response class
which allows users to initiate forwarding to another
extbase controller action.

Returning a ForwardResponse replaces the helper function
forward() in the ActionController.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Torben Hansen +1
    • TYPO3com +1 CI

Issues 1

Files 21

Show 1 more file

Review log 2132

Show 57 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 11/07/20, 12:02

  2. Alexander Schnitzler wrote 11/07/20, 12:02

    Topic set to extbase
  3. Alexander Schnitzler wrote 11/07/20, 12:02

    Hashtag added: psr-7
  4. TYPO3com voted on patch set 1 V -1 11/07/20, 12:18 Completed build in 14m 44s on Sat, 7 Nov, 12:18 PM Test Summary: 290 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7166

  5. Alexander Schnitzler uploaded patch set 2 11/09/20, 09:35

  6. TYPO3com voted on patch set 2 V -1 11/09/20, 09:47 Completed build in 11m 38s on Mon, 9 Nov, 09:47 AM Test Summary: 15 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7198

  7. Alexander Schnitzler uploaded patch set 3 11/09/20, 10:37

  1. TYPO3com voted on patch set 3 V -1 11/09/20, 10:48 Completed build in 11m 15s on Mon, 9 Nov, 10:48 AM Test Summary: 6 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7199

  2. Alexander Schnitzler uploaded patch set 4 11/10/20, 15:55

  3. TYPO3com voted on patch set 4 V +1 11/10/20, 16:07 Completed build in 11m 35s on Tue, 10 Nov, 04:07 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7224

  4. Alexander Schnitzler uploaded patch set 5 11/10/20, 16:37

  5. Alexander Schnitzler uploaded patch set 6 11/10/20, 16:45

  6. TYPO3com voted on patch set 6 V -1 11/10/20, 16:45 Completed build in 20s on Tue, 10 Nov, 04:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7226

  7. Alexander Schnitzler uploaded patch set 7 11/10/20, 16:46

  8. TYPO3com voted on patch set 5 V +1 11/10/20, 16:49 Completed build in 11m 21s on Tue, 10 Nov, 04:49 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7225

  9. TYPO3com voted on patch set 7 V +1 11/10/20, 16:58 Completed build in 11m 59s on Tue, 10 Nov, 04:58 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7227

  10. Alexander Schnitzler uploaded patch set 8 11/16/20, 13:04

  11. TYPO3com voted on patch set 8 V -1 11/16/20, 13:26 Completed build in 21m 48s on Mon, 16 Nov, 01:26 PM Test Summary: 5055 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7344

  12. TYPO3com voted on patch set 8 V +1 11/16/20, 15:07 Completed build in 2h 24m 40s on Mon, 16 Nov, 03:07 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7344

  13. Alexander Schnitzler commented on patch set 8 11/16/20, 15:08

    This change is ready for review.
  14. Alexander Schnitzler uploaded patch set 9 12/02/20, 11:24

  15. TYPO3com voted on patch set 9 V +1 12/02/20, 11:34 Completed build in 09m 53s on Wed, 2 Dec, 11:34 AM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7744

  16. Alexander Schnitzler commented on patch set 9 12/02/20, 11:48

    ActionController.php:855

    This should be a sprintf
  17. Andreas Kienast commented on patch set 9 12/03/20, 09:34

    compatible

    ForwardResponse.php:26

    We may use proper type declarations now.
  18. Alexander Schnitzler commented on patch set 9 CR -1 12/03/20, 12:36

    ForwardResponse.php:26 Reply

    Will rework the patch.
  19. Alexander Schnitzler uploaded patch set 10 12/03/20, 12:43

  20. TYPO3com voted on patch set 10 V +1 12/03/20, 12:54 Completed build in 10m 54s on Thu, 3 Dec, 12:54 PM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7756

  21. Torben Hansen voted on patch set 10 V +1 CR +1 12/03/20, 18:10

  22. Alexander Schnitzler commented on patch set 10 12/04/20, 08:25

    Reply

    Done

    ForwardResponse.php:26 Reply

    Done

    ActionController.php:855 Reply

    Done
  23. Andreas Kienast voted on patch set 10 CR +1 12/04/20, 10:22

  24. Benni Mack voted on patch set 10 V +2 CR +2 12/05/20, 20:51

  25. Benni Mack merged patch set 11 12/05/20, 20:51