66564[FEATURE] Introduce ForwardResponse for extbase
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Torben Hansen +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Torben Hansen +1
- TYPO3com +1 CI
Issues 1
Files 21
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php+5 −4
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-92815-ActionControllerforwardIsDeprecated.rstnew+74 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-92815-IntroduceForwardResponseForExtbase.rstnew+69 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/AbstractController.php+3 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/ContentController.php+2 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/QueueController.php+13 −3
- typo3/sysext/extbase/Classes/Http/ForwardResponse.php3new+111 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php2+26 −15
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php+32 −0
- typo3/sysext/extbase/Classes/Mvc/Request.php+5 −5
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php+2 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/Fixture/Controller/ArgumentTestController.php+4 −7
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php+10 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php+20 −8
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+2 −1
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+3 −2
- typo3/sysext/felogin/Classes/Controller/LoginController.php+13 −9
- typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php+38 −35
- typo3/sysext/filelist/Classes/Controller/FileListController.php+3 −2
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+2 −1
Review log 2132
Show 57 earlier messages
-
Alexander Schnitzler uploaded patch set 1 11/07/20, 12:02
-
Alexander Schnitzler wrote 11/07/20, 12:02
Topic set to extbase -
Alexander Schnitzler wrote 11/07/20, 12:02
Hashtag added: psr-7 -
TYPO3com voted on patch set 1 V -1 11/07/20, 12:18 Completed build in 14m 44s on Sat, 7 Nov, 12:18 PM Test Summary: 290 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7166
-
Alexander Schnitzler uploaded patch set 2 11/09/20, 09:35
-
TYPO3com voted on patch set 2 V -1 11/09/20, 09:47 Completed build in 11m 38s on Mon, 9 Nov, 09:47 AM Test Summary: 15 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7198
-
Alexander Schnitzler uploaded patch set 3 11/09/20, 10:37
-
TYPO3com voted on patch set 3 V -1 11/09/20, 10:48 Completed build in 11m 15s on Mon, 9 Nov, 10:48 AM Test Summary: 6 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7199
-
Alexander Schnitzler uploaded patch set 4 11/10/20, 15:55
-
TYPO3com voted on patch set 4 V +1 11/10/20, 16:07 Completed build in 11m 35s on Tue, 10 Nov, 04:07 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7224
-
Alexander Schnitzler uploaded patch set 5 11/10/20, 16:37
-
Alexander Schnitzler uploaded patch set 6 11/10/20, 16:45
-
TYPO3com voted on patch set 6 V -1 11/10/20, 16:45 Completed build in 20s on Tue, 10 Nov, 04:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7226
-
Alexander Schnitzler uploaded patch set 7 11/10/20, 16:46
-
TYPO3com voted on patch set 5 V +1 11/10/20, 16:49 Completed build in 11m 21s on Tue, 10 Nov, 04:49 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7225
-
TYPO3com voted on patch set 7 V +1 11/10/20, 16:58 Completed build in 11m 59s on Tue, 10 Nov, 04:58 PM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7227
-
Alexander Schnitzler uploaded patch set 8 11/16/20, 13:04
-
TYPO3com voted on patch set 8 V -1 11/16/20, 13:26 Completed build in 21m 48s on Mon, 16 Nov, 01:26 PM Test Summary: 5055 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7344
-
TYPO3com voted on patch set 8 V +1 11/16/20, 15:07 Completed build in 2h 24m 40s on Mon, 16 Nov, 03:07 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7344
-
Alexander Schnitzler commented on patch set 8 11/16/20, 15:08
This change is ready for review. -
Alexander Schnitzler uploaded patch set 9 12/02/20, 11:24
-
TYPO3com voted on patch set 9 V +1 12/02/20, 11:34 Completed build in 09m 53s on Wed, 2 Dec, 11:34 AM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7744
-
Alexander Schnitzler commented on patch set 9 12/02/20, 11:48
ActionController.php:855This should be a sprintf -
Andreas Kienast commented on patch set 9 12/03/20, 09:34
compatibleForwardResponse.php:26We may use proper type declarations now. -
Alexander Schnitzler commented on patch set 9 CR -1 12/03/20, 12:36
ForwardResponse.php:26ReplyWill rework the patch. -
Alexander Schnitzler uploaded patch set 10 12/03/20, 12:43
-
TYPO3com voted on patch set 10 V +1 12/03/20, 12:54 Completed build in 10m 54s on Thu, 3 Dec, 12:54 PM Test Summary: 32405 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7756
-
Torben Hansen voted on patch set 10 V +1 CR +1 12/03/20, 18:10
-
Alexander Schnitzler commented on patch set 10 12/04/20, 08:25
Reply
DoneForwardResponse.php:26ReplyDoneActionController.php:855ReplyDone -
Andreas Kienast voted on patch set 10 CR +1 12/04/20, 10:22
-
Benni Mack voted on patch set 10 V +2 CR +2 12/05/20, 20:51
-
Benni Mack merged patch set 11 12/05/20, 20:51