Review 9.5 Merged

66565[TASK] Enforce Composer 2 usage for TYPO3 development

Helmut Hummel CR +2 V +2 Hard +346 −406 updated 11/16/20, 16:57

Commit message

To benefit from faster operations and cleaner updates
Composer 2 usage is now enforced by requiring ^2.0
of composer-runtime-api.

Although currently there is no real code dependency yet
to the runtime API introduced for Composer 2, this
requirement enforces usage of Composer 2 for all interactions
with this package (install/ update).

The package is required as dev dependency to still
allow "manual" usage of this package for classic installs
and make the breaking impact low (composer install --no-dev
will still work with Composer 1)

For TYPO3 v11 this dependency will likely be a production
dependency as well.

composer up --lock
composer req --dev composer-runtime-api:^2.0

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
  • Verified V +2 Done
    • Helmut Hummel +2

Issues 1

Files 2

Review log 56

  1. Helmut Hummel uploaded patch set 1 11/07/20, 12:08

  2. Helmut Hummel voted on patch set 1 V +2 CR +2 11/07/20, 12:10

  3. Helmut Hummel merged patch set 2 11/07/20, 12:10

  4. TYPO3com voted on patch set 1 V +1 11/07/20, 12:27 Completed build in 18m 17s on Sat, 7 Nov, 12:27 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-870

  5. Dmitry Dulepov commented on patch set 2 11/16/20, 13:32

    It is safe to make such changes in the maintenance versions like 9 and 10? Composer 2 is more restrictive than composer 1, it may break many existing installations. This is not supposed to happen in stable versions.
  6. Michael Stucki commented on patch set 2 11/16/20, 16:57

    Not sure if I got this right. Does this mean that the next TYPO3 security update will only install if I switch my setup to Composer 2? If that's the case then I would prefer to revert this change. Otherwise, it needs to be communicated very clearly that this requirement has changed.