Review main Merged

66569[FEATURE] Allow more DBMS-Versions for local testing

Anja Leichsenring CR +2 V +2 Normal +136 −73 updated 11/10/20, 09:24

Commit message

The formerly hard coded DBMS versions the local testing script
Build/Scripts/runTests.sh received more options to run almost
all supported DBMS versions by passing addidional parameters.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • Patrick Schriner +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Gilli +1
    • Patrick Schriner +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1420

  1. Anja Leichsenring uploaded patch set 1 11/08/20, 09:03

  2. Simon Gilli commented on patch set 1 CR +1 11/08/20, 09:13

    Wow, great improvement, thanks for this!
  3. TYPO3com voted on patch set 1 V +1 11/08/20, 09:16 Completed build in 12m 43s on Sun, 8 Nov, 09:16 AM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7184

  4. Simon Gilli commented on patch set 1 V -1 11/08/20, 09:32

    I've some troubles but not sure if it's a local issue: ./Build/Scripts/runTests.sh -s install -d mariadb -i 10.2 fails with 1) BlankPageCest: Install typo3 on mysql Test Acceptance/Install/Mysql/BlankPageCest.php:installTypo3OnMysql [Doctrine\DBAL\Exception\DriverException] An exception occurred while executing 'SHOW DATABASES': Malformed communication packet Same for other versions. ./Build/Scripts/runTests.sh -s install -d mysql -j 5.5 fails with showing the help, also with other versions.
  5. Anja Leichsenring uploaded patch set 2 11/08/20, 09:36

  6. Anja Leichsenring wrote 11/08/20, 09:36

    Topic set to testing
  7. Anja Leichsenring uploaded patch set 3 11/08/20, 09:43

  8. TYPO3com voted on patch set 2 V +1 11/08/20, 09:48 Completed build in 12m 17s on Sun, 8 Nov, 09:48 AM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7185

  9. TYPO3com voted on patch set 3 V -1 11/08/20, 09:56 Completed build in 11m 58s on Sun, 8 Nov, 09:55 AM Test Summary: 1 of 74036 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7186

  10. TYPO3com voted on patch set 3 V +1 11/08/20, 10:02 Completed build in 30m 10s on Sun, 8 Nov, 10:02 AM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7186

  11. Simon Gilli voted on patch set 3 V +1 CR +1 11/08/20, 11:10

  12. Anja Leichsenring uploaded patch set 4 11/08/20, 12:17

  13. TYPO3com commented on patch set 4 11/08/20, 12:29 Completed build in 11m 15s on Sun, 8 Nov, 12:29 PM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7189

  14. Patrick Schriner commented on patch set 4 11/08/20, 18:53

    runTests.sh:245

    This contradicts doc default
  15. Anja Leichsenring commented on patch set 5 11/09/20, 08:49

    Published edit on patch set 4.
  16. Simon Gilli voted on patch set 5 V +1 CR +1 11/09/20, 08:50

  17. Patrick Schriner commented on patch set 5 V +1 CR +1 11/09/20, 08:53

    runTests.sh:245 Reply

    Done
  18. TYPO3com voted on patch set 5 V +1 11/09/20, 09:01 Completed build in 11m 35s on Mon, 9 Nov, 09:01 AM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7197

  19. Benni Mack voted on patch set 5 V +2 CR +2 11/10/20, 09:24

  20. Benni Mack merged patch set 6 11/10/20, 09:24