Review main Merged

66571[TASK] Output test run overview at end of local test run

Anja Leichsenring CR +2 V +2 Easy +39 −0 updated 11/20/20, 12:47

Commit message

In order to improve quick result accessment, a summary
is now outputted at the very end of the local test run.
Details about test suite, php version and DBMS version
are given, together with a clear message whether the test run was
successful or not.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Jonas Eberle +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1420

  1. Anja Leichsenring uploaded patch set 1 11/08/20, 12:17

  2. Anja Leichsenring commented on patch set 1 11/08/20, 12:18

  3. Anja Leichsenring uploaded patch set 2 11/08/20, 12:22

  4. TYPO3com voted on patch set 1 V +1 11/08/20, 12:34 Completed build in 16m 59s on Sun, 8 Nov, 12:34 PM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7190

  5. TYPO3com voted on patch set 2 V +1 11/08/20, 12:38 Completed build in 13m 14s on Sun, 8 Nov, 12:38 PM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7191

  6. Anja Leichsenring uploaded patch set 3 11/08/20, 12:52

  7. Anja Leichsenring wrote 11/08/20, 12:56

    Topic set to testing
  8. Anja Leichsenring uploaded patch set 4 11/08/20, 12:57

  9. Anja Leichsenring uploaded patch set 5 11/08/20, 13:02

  10. TYPO3com voted on patch set 3 V -1 11/08/20, 13:04 Completed build in 12m 11s on Sun, 8 Nov, 01:04 PM Test Summary: 73214 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7192

  11. Simon Gilli commented on patch set 5 V +1 CR +1 11/08/20, 13:05

    Also a great little improvement, thanks!
  12. TYPO3com voted on patch set 4 V +1 11/08/20, 13:14 Completed build in 13m 54s on Sun, 8 Nov, 01:14 PM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7193

  13. TYPO3com voted on patch set 5 V +1 11/08/20, 13:18 Completed build in 13m 48s on Sun, 8 Nov, 01:18 PM Test Summary: 73551 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7194

  14. Simon Gilli updated the commit message in patch set 6 11/10/20, 09:34

  15. Simon Gilli commented on patch set 6 V +1 CR +1 11/10/20, 09:34

    last change updates releases line only
  16. TYPO3com voted on patch set 6 V +1 11/10/20, 09:46 Completed build in 11m 53s on Tue, 10 Nov, 09:46 AM Test Summary: 73641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7213

  17. Jonas Eberle commented on patch set 6 CR +1 11/10/20, 10:37

    runTests.sh:642

    Just a note that this file is now beginning to mix POSIX [ and bash [[ checks and that it is getting some slight smell. It's fine to use bash since the target shell is well defined. It's just the mixture... Just code style, it's correct like that as well.
  18. Anja Leichsenring commented on patch set 6 11/10/20, 18:11

    runTests.sh:642 Reply Unresolved

    noticed that, will clean it up once everything is in place. The whole file gets too big.
  19. Christian Kuhn voted on patch set 6 V +2 CR +2 11/20/20, 12:47

  20. Christian Kuhn merged patch set 7 11/20/20, 12:47