Review 10.4 Merged

66572[BUGFIX] Avoid database errors when translating sys_file (metadata) records

Benni Mack CR +2 V +2 Easy +2 −2 updated 11/06/20, 13:06

Commit message

The TCA definitions for sys_file.fileinfo and sys_file_metadata.fileinfo
were marked "user" but without any database definition, leading
to side-effects when automating translations (e.g. in l10nmgr).

However, they only provide information (= a virtual field), so the
definition should be of type "none".

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack commented on patch set 1 11/06/20, 12:37

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/06/20, 12:48 Completed build in 11m 12s on Fri, 6 Nov, 12:48 PM Test Summary: 74983 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-739

  3. Oliver Klee voted on patch set 1 CR +1 11/06/20, 13:06

  4. Benni Mack voted on patch set 1 V +2 CR +2 11/06/20, 13:06

  5. Benni Mack merged patch set 2 11/06/20, 13:06