Review 9.5 Merged

66574[BUGFIX] Fix type error in TCA table wizard for null values

Benni Mack CR +2 V +2 Easy +1 −1 updated 11/07/20, 12:51

Commit message

When using renderType textTable for text fields in TCA, the controller
will pass the currently stored value to underlying API. This API always
expects a string. Most of the time those fields might have null as
default in persistence leading to a PHP TypeError.

Therefore a check is added which will fall back to empty string as
proper default for internal API.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 46

  1. Benni Mack commented on patch set 1 11/07/20, 10:33

    Cherry Picked from branch 10.4.
  2. Oliver Klee voted on patch set 1 CR +1 11/07/20, 10:37

  3. TYPO3com voted on patch set 1 V -1 11/07/20, 10:50 Completed build in 17m 14s on Sat, 7 Nov, 10:50 AM Test Summary: 1 of 75793 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-868

  4. TYPO3com voted on patch set 1 V +1 11/07/20, 12:11 Completed build in 1h 54m 45s on Sat, 7 Nov, 12:11 PM Test Summary: 75192 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-868

  5. Benni Mack voted on patch set 1 V +2 CR +2 11/07/20, 12:51

  6. Benni Mack merged patch set 2 11/07/20, 12:51