Review 10.4 Merged

66587[BUGFIX] Implement deferred BE image processing consistently

Georg Ringer CR +2 V +2 Hard +574 −60 updated 12/14/20, 20:43

Commit message

Change the implementation of backend deferred image processing
to use a file processor, which is only but always used in the backend.

By doing so all limitations of the current implementation are resolved,
which means, width and height of the image can be set in HTML, to avoid
layout shifts and once the images are processed, they will simply
be delivered by the web server.

Inconsistencies with thumbnail ratio (depending on crop being defined
or not) are also tackled on the go.

While this changes processing configuration for some files,
which triggers a re-generation, it should not matter, as image
processing will be done in parallel on request, making such changes
viable in a bugfix release.

The introduced database field is neither used nor required for the
current implementation, but is introduced to provide a possibility for
third party processors to replace the current implementation with simple
(and persisted) URLs to third party SaaS image processing services.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 1

Files 17

Review log 67

  1. Georg Ringer commented on patch set 1 11/14/20, 19:16

    Cherry Picked from branch master.
  2. Georg Ringer commented on patch set 1 CR -2 11/14/20, 19:17

    currently blocked
  3. TYPO3com voted on patch set 1 V +1 11/14/20, 19:28 Completed build in 11m 21s on Sat, 14 Nov, 07:28 PM Test Summary: 75066 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-782

  4. Tymoteusz Motylewski commented on patch set 1 11/22/20, 16:04

    Why its blocked
  5. Georg Ringer commented on patch set 1 CR 0 11/22/20, 17:57

    didn't want to have that in security release just rushing it into... removed my -2
  6. Georg Ringer voted on patch set 1 V +2 CR +2 12/14/20, 20:43

  7. Georg Ringer merged patch set 2 12/14/20, 20:43