Review 10.4 Merged

66588[BUGFIX] Do not use AdminPanel reference in EXT:frontend code

Benni Mack CR +2 V +2 Easy +7 −2 updated 11/16/20, 19:27

Commit message

With this change an undefined symbol is included when not having
AdminPanel loaded: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66218

This change aims to change the logic for checking if the preview
flag is enabled.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack commented on patch set 1 11/16/20, 14:18

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 11/16/20, 14:34 Completed build in 13m 33s on Mon, 16 Nov, 02:34 PM Test Summary: 75066 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-794

  3. Andreas Kienast voted on patch set 1 CR +1 11/16/20, 15:36

  4. Benni Mack voted on patch set 1 V +2 CR +2 11/16/20, 19:27

  5. Benni Mack merged patch set 2 11/16/20, 19:27